Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(picking): initial flickering #933

Conversation

dunqan
Copy link
Contributor

@dunqan dunqan commented Nov 22, 2023

Closes HRZ-90351

@dunqan dunqan requested a review from a team as a code owner November 22, 2023 12:20
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit 0ac3372
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/655df204d07dee0008f6e9ee

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 0ac3372
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/655df2040b815d0008a7cf9a
😎 Deploy Preview https://deploy-preview-933--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 0ac3372
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/655df204d40a73000720860c
😎 Deploy Preview https://deploy-preview-933--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
3 paths audited
Performance: 31 (no change from production)
Accessibility: 90 (no change from production)
Best Practices: 94 (no change from production)
SEO: 87 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 22, 2023

1 flaky test on run #11515 ↗︎

0 46 3 0 Flakiness 1

Details:

fix initial flickering
Project: Composable Storefront Commit: 0ac3372e2e
Status: Passed Duration: 03:42 💡
Started: Nov 22, 2023 1:10 PM Ended: Nov 22, 2023 1:14 PM
Flakiness  src/integration/product.cy.ts • 1 flaky test • sf-regression

View Output Video

Test Artifacts
Product details page suite > should show product with relations Test Replay Screenshots Video

Review all test suite changes for PR #933 ↗︎

@dunqan
Copy link
Contributor Author

dunqan commented Nov 28, 2023

We want to fix it differently

@dunqan dunqan closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant