-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(labs): strapi integration #955
Merged
supproduction
merged 5 commits into
development
from
feature/hrz-3254-strapi-integration
Nov 29, 2023
Merged
feat(labs): strapi integration #955
supproduction
merged 5 commits into
development
from
feature/hrz-3254-strapi-integration
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-oryx-components canceled.
|
✅ Deploy Preview for dev-composable-storefront canceled.
|
✅ Deploy Preview for dev-fulfillment canceled.
|
3 flaky tests on run #11603 ↗︎
Details:
currencies.cy.ts • 1 flaky test • sf-regression
locales.cy.ts • 1 flaky test • sf-regression
product.cy.ts • 1 flaky test • sf-b2b
Review all test suite changes for PR #955 ↗︎ |
tobi-or-not-tobi
changed the title
feat: strapi integration
feat(labs): strapi integration
Nov 29, 2023
tobi-or-not-tobi
suggested changes
Nov 29, 2023
apps/storefront/.env.template
Outdated
|
||
# The Strapi Access Token | ||
ORYX_STRAPI_TOKEN= | ||
# Url to strapi api. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# Url to strapi api. | |
# Url to Strapi api. While Strapi has a cloud offering, it is common to deploy Strapi on a 3rd party host, or run it locally during development. |
apps/storefront/.env.template
Outdated
@@ -40,3 +40,8 @@ ORYX_PRESET= | |||
|
|||
# Used to set a feature level, available options: latest, 1.0, 1.1, etc. Only major and minor versions should be used. | |||
ORYX_FEATURE_VERSION=latest | |||
|
|||
# The Strapi Access Token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# The Strapi Access Token | |
# The Strapi Access Token. |
tobi-or-not-tobi
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes HRZ-3254