Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: category list improvements #959

Merged
merged 10 commits into from
Dec 1, 2023
Merged

refactor: category list improvements #959

merged 10 commits into from
Dec 1, 2023

Conversation

dunqan
Copy link
Contributor

@dunqan dunqan commented Nov 30, 2023

  • move category list query out of the service
  • use uqery postTransform for category exclude functionality

@dunqan dunqan requested a review from a team as a code owner November 30, 2023 12:13
@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited
Loading

✅ Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit 41cf13a
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/6569a667224776000844b6c1

@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited
Loading

✅ Deploy Preview for dev-oryx-components canceled.

Name Link
🔨 Latest commit 41cf13a
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/6569a6671fad3b0008ffdb1d

@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited
Loading

✅ Deploy Preview for dev-composable-storefront canceled.

Name Link
🔨 Latest commit 41cf13a
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/6569a667224776000844b6bc

@cypress Cypress
Copy link

cypress bot commented Nov 30, 2023 •
edited
Loading

Passing run #11639 ↗︎

0 55 55 0 Flakiness 0

Details:

fix e2e
Project: Composable Storefront Commit: 41cf13a561
Status: Passed Duration: 06:32 💡
Started: Dec 1, 2023 9:28 AM Ended: Dec 1, 2023 9:35 AM

Review all test suite changes for PR #959 ↗︎

dunqan and others added 5 commits December 1, 2023 06:09
@dunqan @tobi-or-not-tobi
Update libs/domain/product/src/models/category-qualifier.ts
ffa322e 
Co-authored-by: tobi-or-not-tobi <tobi-or-not-tobi@users.noreply.github.com>
@dunqan @tobi-or-not-tobi
Update libs/domain/product/src/services/category/default-category.ser…
4ba3819 
…vice.ts

Co-authored-by: tobi-or-not-tobi <tobi-or-not-tobi@users.noreply.github.com>
@dunqan @tobi-or-not-tobi
Update libs/domain/product/src/services/category/state/queries.ts
f11744b 
Co-authored-by: tobi-or-not-tobi <tobi-or-not-tobi@users.noreply.github.com>
@dunqan
fixes
6048738
@dunqan
improvements
0052af3
@dunqan dunqan changed the title refactor:category list improvements refactor: category list improvements Dec 1, 2023
@dunqan dunqan merged commit 73a2ccc into development Dec 1, 2023
37 checks passed
@dunqan dunqan deleted the refactor/category-list-improvements branch December 1, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobi-or-not-tobi tobi-or-not-tobi tobi-or-not-tobi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunqan @tobi-or-not-tobi