Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): cart list components #966

Merged

Conversation

Sinucid
Copy link
Contributor

@Sinucid Sinucid commented Dec 5, 2023

Cart list and cart list item components implementations, with storybook stories and unit tests

closes: HRZ-90080

@Sinucid Sinucid requested a review from a team as a code owner December 5, 2023 08:39
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit bd64c14
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/656ee1db2f8d7b000795d719
😎 Deploy Preview https://deploy-preview-966--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit bd64c14
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/656ee1dba2c1660008ee3608

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit bd64c14
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/656ee1db35a5a500081a8db5
😎 Deploy Preview https://deploy-preview-966--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
3 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sinucid Sinucid changed the base branch from development to task/HRZ-90000-multi-cart-list December 5, 2023 08:40
Copy link

cypress bot commented Dec 5, 2023

Passing run #11713 ↗︎

0 55 55 0 Flakiness 0

Details:

Merge branch 'task/HRZ-90000-multi-cart-list' into feature/hrz-90080-cart-list-c...
Project: Composable Storefront Commit: 2820e9c804
Status: Passed Duration: 03:18 💡
Started: Dec 7, 2023 8:32 AM Ended: Dec 7, 2023 8:36 AM

Review all test suite changes for PR #966 ↗︎

libs/domain/cart/list-item/list-item.component.ts Outdated Show resolved Hide resolved
libs/domain/cart/list-item/list-item.component.ts Outdated Show resolved Hide resolved
libs/domain/cart/list-item/list-item.component.ts Outdated Show resolved Hide resolved
libs/domain/cart/list/list.component.ts Outdated Show resolved Hide resolved
libs/domain/cart/list/list.component.ts Outdated Show resolved Hide resolved
libs/domain/cart/src/models/cart-qualifier.ts Outdated Show resolved Hide resolved
libs/domain/cart/services/src/default-cart.service.ts Outdated Show resolved Hide resolved
@Sinucid Sinucid merged commit b50e44a into task/HRZ-90000-multi-cart-list Dec 7, 2023
23 checks passed
@Sinucid Sinucid deleted the feature/hrz-90080-cart-list-component branch December 7, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants