Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FA fixes #976

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: FA fixes #976

merged 3 commits into from
Dec 11, 2023

Conversation

tolerants
Copy link
Contributor

@tolerants tolerants commented Dec 7, 2023

  • Favicon is now shown in preview mode in fulfillment app
  • Login page layout is fixed
  • Auth loading component layout is fixed

closes: HRZ-90568

@tolerants tolerants requested a review from a team as a code owner December 7, 2023 15:16
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 1eca354
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/6576c0cf380e5300082e5302
😎 Deploy Preview https://deploy-preview-976--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 1eca354
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/6576c0cf2080a30008abc83f
😎 Deploy Preview https://deploy-preview-976--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
3 paths audited
Performance: 30 (🔴 down 3 from production)
Accessibility: 90 (no change from production)
Best Practices: 97 (no change from production)
SEO: 87 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for dev-fulfillment canceled.

Name Link
🔨 Latest commit 1eca354
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/6576c0cf6a308c00089fd0c1

Copy link

cypress bot commented Dec 7, 2023

Passing run #11753 ↗︎

0 57 57 0 Flakiness 0

Details:

Merge remote-tracking branch 'origin/development' into fix/fa-favicon
Project: Composable Storefront Commit: 1eca3547d4
Status: Passed Duration: 03:09 💡
Started: Dec 11, 2023 8:01 AM Ended: Dec 11, 2023 8:04 AM

Review all test suite changes for PR #976 ↗︎

@tolerants tolerants merged commit bb44f58 into development Dec 11, 2023
37 checks passed
@tolerants tolerants deleted the fix/fa-favicon branch December 11, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants