feat(cart): carts pages #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment canceled.
|
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sinucid
changed the base branch from
development
to
task/HRZ-90000-multi-cart-list
1 flaky test on run #11816 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Checkout suite > for authenticated user: > should create a new order successfully |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #990 ↗︎
tolerants
reviewed
Dec 12, 2023
supproduction
requested changes
Dec 12, 2023
dunqan
reviewed
Dec 13, 2023
dunqan
reviewed
Dec 13, 2023
libs/platform/core/src/services/token-resolver/token-resolver.service.ts
Outdated
Show resolved
Hide resolved
Sinucid
changed the title
Passing run #2698 ↗︎
Details:
Review all test suite changes for PR #990 ↗︎ |
|||||||||||||||
tolerants
reviewed
Dec 13, 2023
supproduction
approved these changes
Dec 13, 2023
tolerants
approved these changes
Dec 14, 2023
dunqan
reviewed
Dec 14, 2023
dunqan
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveTokenmethod is accepting options object now instead string token({ token: string, contextElement?: HTMLElement | LitElement}), with token and optional context element that can be used as context providerSUMMARYandEMPTYare able to resolve values within context nowCompositionComponentsControlleris providing host element now as acontextElementfor dynamic visibility rules, to be able to resolve resources within contextcloses: HRZ-90718, HRZ-90086