Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP74 #44

Closed
wants to merge 0 commits into from
Closed

PHP74 #44

wants to merge 0 commits into from

Conversation

dereuromark
Copy link
Contributor

@ehsanmx Please enable some valid smoke tests here

ehsanmx
ehsanmx previously approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@ehsanmx ehsanmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the Travis is green

@dereuromark
Copy link
Contributor Author

Yeah, that will be your ticket to fix up :)

@ehsanmx
Copy link
Contributor

ehsanmx commented Nov 13, 2019 •
edited
Loading

hmm but Travis is red because of SprykerTest\Shared\Testify\Exception\StoreNotFoundException
how is this related to creating tests?
and we have some tests here SprykerTest/Zed/RabbitMq/Business/Model/Exchange/Filter/ExchangeFilterByNameTest.php

@dereuromark
Copy link
Contributor Author

Please check these things then once you find time. Ticket is created here by @RodinVasily

ehsanmx
ehsanmx suggested changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@ehsanmx ehsanmx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the current tests, we can only merge it when everything is fixed!

@dereuromark
Copy link
Contributor Author

Exactly, you need to fix this PR and then once green we can continue.

@dereuromark
Copy link
Contributor Author

@ehsanmx Whats the status on this?

@dereuromark dereuromark mentioned this pull request Feb 4, 2020
Closed
dereuromark
dereuromark commented Feb 27, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@dereuromark dereuromark mentioned this pull request Mar 9, 2020
Merged
4 tasks
@dereuromark
Copy link
Contributor Author

dereuromark commented May 18, 2020 •
edited
Loading

Any update here? We should finish and merge this.

And tests are still critically missing.

@dereuromark
Copy link
Contributor Author

ping @ehsanmx

@RodinVasily
Copy link
Contributor

Aha feature: https://spryker.aha.io/features/TECH-350

@dereuromark dereuromark mentioned this pull request Aug 11, 2020
Merged
4 tasks
@dereuromark dereuromark closed this Nov 4, 2020
@dereuromark dereuromark deleted the php74 branch November 4, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsanmx ehsanmx ehsanmx requested changes

Assignees

@ehsanmx ehsanmx

Labels
improvement prio
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereuromark @ehsanmx @RodinVasily