-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TE-10005: Fixed up missing constraints #62
Merged
spryker-release-bot
merged 6 commits into
master
from
feature/te-10005/master-fixed-up-missing-constraints
Oct 13, 2021
Merged
TE-10005: Fixed up missing constraints #62
spryker-release-bot
merged 6 commits into
master
from
feature/te-10005/master-fixed-up-missing-constraints
Oct 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dereuromark
approved these changes
Oct 12, 2021
why is there no CI run? |
Template invalid, see RG validation for "Module Benchmark" |
matweew
reviewed
Oct 13, 2021
strategy: | ||
fail-fast: false | ||
matrix: | ||
php-version: [ | ||
'7.3', | ||
'7.4' | ||
'8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7.4+ could also be a follow up.
spryker-release-bot
deleted the
feature/te-10005/master-fixed-up-missing-constraints
branch
October 13, 2021 18:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer(s): @olhalivitchuk
Ticket: https://spryker.atlassian.net/browse/TE-10005
Academy PR: ACADEMY_URL_HERE
Release Group: https://release.spryker.com/release-groups/view/3844
merge: merge
Release Table
Module RabbitMq
Change log
Improvements
php-amqplib/php-amqplib
version, as this one is PHP 8.0+ compatible.