Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/utils.py seems to be missing from the 0.2.8 tarball #75

Closed
keszybz opened this issue Jan 23, 2015 · 5 comments · Fixed by #80
Closed

tests/utils.py seems to be missing from the 0.2.8 tarball #75

keszybz opened this issue Jan 23, 2015 · 5 comments · Fixed by #80

Comments

@keszybz
Copy link

keszybz commented Jan 23, 2015

Tests fail with

ImportError: cannot import name 'utils'
@spulec
Copy link
Owner

spulec commented Feb 8, 2015

I had not intended for the tests to be included with the distributions. That is now fixed with 47bcd0f.

Thanks.

@spulec spulec closed this as completed Feb 8, 2015
@keszybz
Copy link
Author

keszybz commented Feb 8, 2015

Hm, but why? Running tests is a nice way to check that things are OK. Not just in freezegun itself, but e.g. in dependencies.

@spulec
Copy link
Owner

spulec commented Feb 8, 2015

This was the original reason. I'm open to alternative suggestions, but tend to be -0 on things like a nested tests directory inside of the freezegun module.

@pypingou
Copy link
Contributor

pypingou commented Feb 8, 2015

You can ship the tests in the tarball without nesting them in the module itself (because they should not be installed).

@keszybz
Copy link
Author

keszybz commented Feb 8, 2015

I think that #27 was bogus. If I revert HEAD (so I'm effectively at freezegun@7da4cef779),

pip install .

does not install tests. Neither does

pip install freezegun==0.2.8

Neither does

python setup.py install --user

Nor

python setup.py sdist
pip install `pwd`/dist/freezegun-0.2.8.tar.gz --user  

I think that the reporter from #27 might have had an old egg in his git checkout directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants