++TickingDateTimeFactory.move_to #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added missing move_to, resolves #350
bblommers
requested changes
Feb 15, 2024
There was a problem hiding this comment.
Hi @ashishnitinpatil, thank you for the PR!
The move_to should update the start-attribute as well, as that is used to calculate how much time has progressed.
Can we also get a test for this in test_ticking.py? That file contains a few other tests that you can use for inspiration.
|
Thanks for the comments @bblommers. I created another (couldn't edit the branch) PR resolving the comment suggestions - #533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing move_to, resolves #350