PR: Update load_font documentation
#198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add examples and update description according to the actually implemented 'directory' kwarg handling
ccordoba12
changed the title
load_font documentation
ccordoba12
reviewed
Dec 21, 2021
There was a problem hiding this comment.
Thanks @dalthviz! I left some small suggestions for you, otherwise looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add examples and update the description according to the actually implemented
directorykwarg handlingFixes #195
Also, jus in case, I added the
readthedocspreview to the checks. So to check the changes done in the docs you can go to: https://qtawesomedocs--198.org.readthedocs.build/en/198/ (or check thedetailslink in thereadthedocscheck)