Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add compatibility with PySide2 without impacting PyQt5 #84

Closed
wants to merge 2 commits into from

Conversation

stonebig
Copy link

@stonebig stonebig commented May 9, 2018

No description provided.

@ccordoba12 ccordoba12 changed the title compatibility with PySide2-5.11a1 without impacting PyQt5 PR: Add compatibility with PySide2 without impacting PyQt5 May 9, 2018
@ccordoba12
Copy link
Member

Does this supersedes PR #81?

@stonebig
Copy link
Author

stonebig commented May 9, 2018

Yes. In the process of making PySide2 more usefull, and so getting more users fighting bugs:

  • I converted guidata to 'QtPy' vendored,
  • it required this patch.

Now:

  • I have a guidata working, (at 80%)
  • but Spyder still doesn't start.

@ccordoba12
Copy link
Member

Let's use #81, which is simpler.

@ccordoba12 ccordoba12 closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants