Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update README.md adding a line for QtPy usefulness when migrating between Qt bindings/versions #301

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Dec 14, 2021

Fixes #62

@dalthviz dalthviz added this to the v2.0.0 milestone Dec 14, 2021
@dalthviz dalthviz self-assigned this Dec 14, 2021
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dalthviz , sorry I have been extremely busy and thanks for helping take care of this! Hopefully we can merge this soon, since it is a de-facto blocker to my work on #85 and #61 due to the likelihood of major merge conflicts. Thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@dalthviz dalthviz changed the title PR: Update README.md adding a line for QtPy usefulness when migration between Qt bindings/versions PR: Update README.md adding a line for QtPy usefulness when migrating between Qt bindings/versions Dec 15, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz and @CAM-Gerlach for this! I left some small suggestions, otherwise looks good to me.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@dalthviz
Copy link
Member Author

Could you merge this if is ok with you @CAM-Gerlach ? Thanks!

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dalthviz !

@CAM-Gerlach CAM-Gerlach merged commit a678303 into spyder-ide:master Dec 16, 2021
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Dec 16, 2021

(@dalthviz I squashed it since there were two duplicate "apply changes from code review" commits and it was a fairly self-contained change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to the readme the importance of qtpy when migrating an application
3 participants