PR: Migrate Find in files plugin to new API

[goanpeca]

Description of Changes

• Wrote at least one-line docstrings (for any new functions)
• Added unit test(s) covering the changes (if testable)

• Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #12189

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

[pep8speaks]

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-14 17:00:21 UTC

[goanpeca]

Rebased and ready for review @ccordoba12

[goanpeca]

Hi @dalthviz, this one is ready for QA testing when you have some time. Thanks!

[dalthviz]

After an initial test seems like all the actions work as expected. LGTM 👍

[goanpeca]

This one is ready for review @ccordoba12

[ccordoba12]

@goanpeca, some small comments for you and (unfortunately) tests are failing.

[dalthviz]

An error raises when running now (maybe a missing sig_ when connecting a signal from the Working Directory @goanpeca ?):

[goanpeca]

@dalthviz that has been fixed already https://github.com/spyder-ide/spyder/pull/12382/files#diff-449a26d3a4d2cdde344b13b43e1fb864R71, I think you needed to pull/refresh your local branch.

[dalthviz]

Yep @goanpeca I was missing reseting my local with the latest changes 👍 Checking them I found this:

• The exclude combobox is empty:
  

• When undocking some actions are disabled:
  

• After undocking and clicking the X the undock action gets disabled (not sure of a way to consistently reproduce this though):
  

[goanpeca]

The exclude combobox is empty:

Will look into it

When undocking some actions are disabled:

Will fix!

fter undocking and clicking the X the undock action gets disabled (not sure of a way to consistently reproduce this though):

May be related to the things reported on the Plots plugin? I fixed those issues on that PR.

[dalthviz]

Maybe related to the things reported on the Plots plugin? I fixed those issues on that PR.
Um maybe, although the initial issue was that closing the pane with X caused the pane to disappear completely from Spyder.

Maybe could be better to merge first the plots PR to get the fix implemented and then update this PR to check if the issue remains or is fixed?

[ccordoba12]

Maybe could be better to merge first the plots PR to get the fix implemented and then update this PR to check if the issue remains or is fixed?

Ok, will look into that PR later today so we can merge that one first then this one.

Thank you both for your help.

[goanpeca]

This is ready for review @ccordoba12

[dalthviz]

Just in case, seems like a merge/rebase needs to be done here @goanpeca (maybe only worthy after #12196 is merged)

[goanpeca]

Will fix!

[goanpeca]

Fixed @dalthviz

[ccordoba12]

@goanpeca, some small comments and then this should be ready.

[goanpeca]

Updated @ccordoba12.

[ccordoba12]

@goanpeca, this is ready. Please squash and rebase so I can merge it.

[goanpeca]

The pip failures are unrelated. Merging.