Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make middle mouse button click on editor tabs close the intended tab #12617

Merged
merged 2 commits into from
May 15, 2020

Conversation

steff456
Copy link
Member

@steff456 steff456 commented May 5, 2020

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Add offset to remain the region of tab given an event and be able to close intended tab

tab

Issue(s) Resolved

Fixes #12558

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Steff456

@steff456 steff456 changed the base branch from master to 4.x May 5, 2020 23:40
@ccordoba12 ccordoba12 requested a review from dalthviz May 6, 2020 02:25
@ccordoba12
Copy link
Member

Nice job @steff456!

@dalthviz, please test this PR on Windows to see if it's working as expected there. I'll test this one on my KDE desktop too.

@dalthviz
Copy link
Member

dalthviz commented May 6, 2020

@ccordoba12 it works for me on Windows 👍

@ccordoba12
Copy link
Member

@steff456, please don't forget to check if this works with a change in the scaling factor of your screen so we can merge it.

@ccordoba12
Copy link
Member

@steff456, please don't forget to check if this works with a change in the scaling factor of your screen so we can merge it.

@steff456 confirmed with me that this PR works for her on macOS with different scale factors, so I'd say this is ready.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here @steff456!!

@ccordoba12 ccordoba12 changed the title PR: Middle mouse button click on editor tabs close intended tab PR: Make middle mouse button click on editor tabs close the intended tab May 15, 2020
@ccordoba12 ccordoba12 merged commit 539ee37 into spyder-ide:4.x May 15, 2020
ccordoba12 added a commit that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middle mouse button click on editor tabs may close wrong tab
4 participants