Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement mouse XButton navigation in the editor #17786

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

maurerle
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

I added navigation with XButtons (the typical extra two buttons on a mouse used for browsing backward and forward) in the code editor.
This improves code browsing if the mouse has this ability.

I don't know if this is testable and how, as it only adds a new trigger which is forwarded to the one in the EditorStack.

Issue(s) Resolved

Fixes #15948

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Florian Maurer

@ccordoba12
Copy link
Member

Hey @maurerle, thanks a lot for your contribution! To have it in one of the next releases in the Spyder 5 cycle, please make your branch to derive from our 5.x one (instead of master), with the following commands:

git checkout 5.x
git checkout feature/xbutton
git rebase --onto 5.x master feature/xbutton
git push -f origin feature/xbutton

You need to do the same for the other pull requests that you opened today. More details about our development process are available in our Contributing guide.

@maurerle
Copy link
Contributor Author

Thank you!
I updated all my contributions. Could you please review them and give feedback?

@ccordoba12 ccordoba12 changed the base branch from master to 5.x April 29, 2022 14:55
@ccordoba12 ccordoba12 changed the title PR: implement mouse XButton navigation in editor PR: Implement mouse XButton navigation in the editor Apr 29, 2022
@ccordoba12
Copy link
Member

I don't have much free time these days, but I'll ask @dalthviz (one of our core developers) to take a look at them.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maurerle for this! Checked locally and is working. Quite nice improvement in the navigation experience if you have a mouse with extra buttons on the side indeed 👍

@dalthviz dalthviz added this to the v5.3.1 milestone Apr 29, 2022
@dalthviz dalthviz merged commit b415aa8 into spyder-ide:5.x Apr 29, 2022
dalthviz added a commit that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support XButton1 and XButton2
3 participants