Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Create loading screen for the Dependencies widget, and added new icons for dependencies, debug, console-off and console-remote-off #21271

Merged
merged 11 commits into from
Sep 19, 2023

Conversation

conradolandia
Copy link
Contributor

@conradolandia conradolandia commented Aug 18, 2023

Description of Changes

  • Made a loading screen for the dependencies widget. Now it shows an animated spinner, an icon and a message while the dependencies are calculated.

New icons added to spyder/images

  • console-off.svg
  • console-remote-off.svg
  • dependencies.svg
  • debug.svg

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @conradolandia

@ccordoba12 ccordoba12 changed the title Create loading screen for the Dependencies widget, and added new icons for dependencies, debug, console-off and console-remote-off PR: Create loading screen for the Dependencies widget, and added new icons for dependencies, debug, console-off and console-remote-off Aug 22, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice improvements, thanks @conradolandia!

spyder/plugins/application/container.py Outdated Show resolved Hide resolved
spyder/utils/qthelpers.py Outdated Show resolved Hide resolved
spyder/widgets/helperwidgets.py Outdated Show resolved Hide resolved
spyder/widgets/helperwidgets.py Outdated Show resolved Hide resolved
@ccordoba12
Copy link
Member

@conradolandia, one thing that's missing is for you to actually use the new console-off icon in our code. For that, please go to this file:

widget = PaneEmptyWidget(
self,
"variable-explorer", # TODO: Use custom icon here
_("No connected console"),
_("The current console failed to start, so there is no "
"content to show here.")
)

replace variable-explorer by console-off in line 137 and remove the comment next to it.

conradolandia and others added 7 commits August 22, 2023 14:55
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new icons. Great work @conradolandia!

@CAM-Gerlach CAM-Gerlach merged commit a894eb6 into spyder-ide:master Sep 19, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants