Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Escape backslashes when replacing all occurrences of some text by another with them (Find/Replace) #21457

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Oct 25, 2023

Description of Changes

  • This problem happens when users try to replace all occurrences of some text by an expression that contains backslashes.
  • Also, add a regression test for this case.

Issue(s) Resolved

Fixes #21007

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

- This problem happens when users try to replace all occurrences of some
text by an expression that contains backslashes.
- Also, add a regression test for this case.
@ccordoba12 ccordoba12 added this to the v5.5.0 milestone Oct 25, 2023
@ccordoba12 ccordoba12 self-assigned this Oct 25, 2023
@ccordoba12 ccordoba12 changed the title PR: Escape backslashes in replace_find_all method (Find/Replace) PR: Escape backslashes when replacing all occurrences of some text (Find/Replace) Oct 25, 2023
@ccordoba12 ccordoba12 changed the title PR: Escape backslashes when replacing all occurrences of some text (Find/Replace) PR: Escape backslashes when replacing all occurrences of some text by another with them (Find/Replace) Oct 25, 2023
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 !

@dalthviz dalthviz merged commit 6d53101 into spyder-ide:5.x Oct 25, 2023
22 checks passed
@ccordoba12 ccordoba12 deleted the issue-21007 branch October 25, 2023 22:59
dalthviz added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants