PR: Create a base class for sidebar dialogs (Widgets) #21734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will be the base page used in sidebar dialogs. - Also, move some methods from it to SpyderConfigPage because they are only used in that class and don't apply for a generic sidebar page.
This helps to avoid warnings or problems about those values in our tests.
Also, make another method private.
jitseniesen
added a commit
to spyder-ide/spyder-unittest
that referenced
this pull request
Apr 8, 2024
As a side-effect of PR spyder-ide/spyder#21734, a QApplication needs to be running before importing spyder.plugins.preferences.widgets.configdialog. Moving the import inside a function achieves this.
jitseniesen
added a commit
to jitseniesen/spyder-unittest
that referenced
this pull request
Apr 8, 2024
As a side-effect of PR spyder-ide/spyder#21734, a QApplication needs to be running before importing spyder.plugins.preferences.widgets.configdialog. Moving the import inside a function achieves this.
jitseniesen
added a commit
to jitseniesen/spyder-unittest
that referenced
this pull request
Apr 12, 2024
As a side-effect of PR spyder-ide/spyder#21734, a QApplication needs to be running before importing spyder.plugins.preferences.widgets.configdialog. Moving the import inside a function achieves this.
jitseniesen
added a commit
to jitseniesen/spyder-notebook
that referenced
this pull request
May 28, 2024
As a side-effect of PR spyder-ide/spyder#21734, a QApplication needs to be running before importing spyder.plugins.preferences.widgets.configdialog. Moving the import inside a function achieves this.
jitseniesen
added a commit
to jitseniesen/spyder-notebook
that referenced
this pull request
May 28, 2024
As a side-effect of PR spyder-ide/spyder#21734, a QApplication needs to be running before importing spyder.plugins.preferences.widgets.configdialog. Moving the import inside a function achieves this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
ConfigDialogclass we use to display our preferences by moving most of its code to a newSidebarDialogone placed inspyder/widgets/sidebardialog.pyVisual changes
This is a screenshot of a simple sidebar dialog with two pages.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12.