Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make SpyderPalette inherit from QDarkStyle palettes and remove QStylePalette #21844

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

conradolandia
Copy link
Contributor

Description of Changes

  • Add DarkPalette and LightPalette as arguments to the classes SpyderPaletteDark and SpyderPaletteLight
  • Replace all instances of QStylePalette with SpyderPalette

This work is a part of an effort to integrate the color palettes. This is a pre-requisite of the project towards a themable UI for the applicattion.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@conradolandia

@ccordoba12 ccordoba12 added this to the v6.0beta1 milestone Mar 1, 2024
@ccordoba12 ccordoba12 changed the title Refactoring QStylePalette as SpyderPalette PR: Make SpyderPalette inherit from QDarkStyle palettes and remove QStylePalette Mar 1, 2024
@ccordoba12 ccordoba12 modified the milestones: v6.0alpha5, v6.0beta1 Mar 12, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @conradolandia!

@ccordoba12 ccordoba12 merged commit 2b2024a into spyder-ide:master Mar 25, 2024
14 checks passed
jitseniesen added a commit to jitseniesen/spyder-unittest that referenced this pull request Apr 6, 2024
jitseniesen added a commit to jitseniesen/spyder-unittest that referenced this pull request Apr 12, 2024
jitseniesen added a commit to jitseniesen/spyder-unittest that referenced this pull request Apr 15, 2024
jitseniesen added a commit to jitseniesen/spyder-unittest that referenced this pull request Apr 16, 2024
jitseniesen added a commit to jitseniesen/spyder-notebook that referenced this pull request Apr 29, 2024
jitseniesen added a commit to jitseniesen/spyder-notebook that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants