➕ Added ToolTip, TrayTip and return types to window functions #92

yemreak · 2020-07-16T21:51:27Z

Hello, I came back ✋

➕ I added:

Return type to some methods to help code completion
ToolTip and TrayTip GUI with GUIMixin structure also gui.py file and templates

Also formatted via black with -S -l 120 args

yemreak · 2020-07-17T16:59:29Z

ahk/gui.py

+    def _show_traytip(self, title: str, text: str, second=1.0, type_id=1, slient=False, large_icon=False, blocking=True):
+        """Show TrayTip (Windows 10 toast notification)
+
+        https://www.autohotkey.com/docs/commands/TrayTip.htm
+
+        :param title: Title of notification
+        :type title: str
+        :param text: Content of notification
+        :type text: str
+        :param second: Wait time (s) to be disappeared, defaults to 1.0
+        :type second: float, optional
+        :param type_id: Notification type `TRAYTIP_<type>`, defaults to 1
+        :type type_id: int, optional
+        :param slient: Shows toast without sound, defaults to False
+        :type slient: bool, optional
+        :param large_icon: Shows toast with large icon, defaults to False
+        :type large_icon: bool, optional
+        """
+
+        option = type_id + (16 if slient else 0) + (32 if large_icon else 0)
+        script = self.render_template("gui/traytip.ahk", title=title, text=text, second=second, option=option)
+        self.run_script(script, blocking=blocking)


Can not show "utf-8" text like şğüı need help @spyoungtech

I believe this is a known limitation in several areas and has to do with how encoding is interpreted when sending the script via stdin, which may not be the same across systems. I have some theories on how AHK handles non-ascii input, but I haven't looked into much or confirmed; see #45

Currently, the best-supported method for non-ascii is to send along AHK-unicode sequences like {U+2F72}. Can you give that a try and see if it works?

For example şğüı might best be sent as {u+015f}{u+011f}{u+00fc}{u+0131}

If it works with the unicode escapes, I'm happy to merge in as-is.

Sorry but I didn't work 🤕

I found some way to do this. When I send like this, it's work 🎉

We may decode unicode u'\U0001f618 \U0001f375' to Chr(0x1f618) Char(0x1f375) # 😘 🍵

Maybe this would helpfully "🚀".encode("unicode_escape") ref

hval = hex(ord("🚀")) # '0x1f680' we may use it for f"Chr({hval})"

ahk.show_tooltip('% Chr(0x1F680)') # Rocket 🚀

Char code table

Finally, I found usable solution:

from ahk import AHK ahk = AHK() string = 'Rocket 🚀 man' ahk_string = "% " for char in string: hval = hex(ord(char)) ahk_string += f"Chr({hval})" ahk.show_tooltip(ahk_string)

yemreak · 2020-07-17T18:15:06Z

#11 #40

spyoungtech · 2020-07-17T18:34:15Z

If possible, can you split out the tooltip/traytip changes and the return types for window functions into their own separate changesets and PRs?

Thanks!

This reverts commit d3627ea.

yemreak · 2020-07-17T18:47:05Z

If possible, can you split out the tooltip/traytip changes and the return types for window functions into their own separate changesets and PRs?

Thanks!

I reverted commit

ahk/script.py

ahk/autohotkey.py

tests/unittests/test_gui.py

This reverts commit c9dea4c.

yemreak · 2020-07-18T08:33:44Z

Could you make "Squash and merge" instead of "Merge" to show users tidy?

…h#86

yemreak · 2020-07-18T22:27:49Z

ahk/gui.py

+        encoded_title = "% " + "".join([f"Chr({hex(ord(char))})" for char in title])
+        encoded_text = "% " + "".join([f"Chr({hex(ord(char))})" for char in text])


Unicode encoding for AHK

yemreak · 2020-07-18T22:28:05Z

ahk/gui.py

+        if id and not (1 <= int(id) <= 20):
+            raise ValueError("ID value must be between [1, 20]")
+
+        encoded_text = "% " + "".join([f"Chr({hex(ord(char))})" for char in text])


Unicode encoding for AHK

yemreak · 2020-07-18T22:28:27Z

tests/unittests/test_gui.py

+        ahk.show_tooltip("hello")
+        ahk.show_tooltip("🚀 Hello unicode 🚀", second=2)
+        ahk.show_tooltip("⽲ hello3", x=10, y=10)
+        ahk.show_tooltip("hello4", second=2, x=10, y=10)


Unicode tooltip test

yemreak · 2020-07-18T22:28:37Z

tests/unittests/test_gui.py

+        ahk._show_traytip("⽲ Normal 🚀", "It's me")
+        ahk._show_traytip("🐌 Slow 🐌", "It's you", second=2)


Unicode traytip test

yemreak · 2020-07-18T22:30:33Z

I found some way to do this. When I send like this, it's work 🎉

We may decode unicode u'\U0001f618 \U0001f375' to Chr(0x1f618) Char(0x1f375) # 😘 🍵
Maybe this would helpfully "🚀".encode("unicode_escape") ref
hval = hex(ord("🚀")) # '0x1f680' we may use it for f"Chr({hval})"

ahk.show_tooltip('% Chr(0x1F680)') # Rocket 🚀

Char code table

Finally, I found usable solution:

from ahk import AHK

ahk = AHK()

string = 'Rocket 🚀 man'
ahk_string = "% "
for char in string:
    hval = hex(ord(char))
    ahk_string += f"Chr({hval})"

ahk.show_tooltip(ahk_string)

Added encoded_title = "% " + "".join([f"Chr({hex(ord(char))})" for char in title]) line to necessary part of codes and tested manually 🎉

yemreak · 2020-08-23T19:39:23Z

Hey, Could you check the PR 😕 @spyoungtech

spyoungtech · 2020-09-02T18:47:34Z

Hi @yedhrab apologies for the long delay. I'm not sure when I will be able to get around to this, but I'm hoping it will be some time in the next couple weeks for both the open PRs. But I haven't forgotten about this :)

spyoungtech · 2020-09-07T10:45:52Z

Thank you for the contribution @yedhrab I've squashed and merged to master and these changes will be included in the next release!

Cheers,
Spencer

spyoungtech · 2020-09-07T13:19:13Z

Released in v0.10.0

yemreak added 4 commits July 17, 2020 00:48

👨‍💻 Added return types to window functions

d3627ea

➕ ToolTip GUI added

b73dc80

👨‍🔧 Tooltip params changed "second" -> "ms"

3e0ba6e

➕ Traytip and it's tests added

51fd760

yemreak changed the title ~~👨‍💻 Added return types to window functions~~ 👨‍💻 Added ToolTip, TrayTip and return typesto window functions Jul 17, 2020

yemreak changed the title ~~👨‍💻 Added ToolTip, TrayTip and return typesto window functions~~ ➕ Added ToolTip, TrayTip and return typesto window functions Jul 17, 2020

yemreak changed the title ~~➕ Added ToolTip, TrayTip and return typesto window functions~~ ➕ Added ToolTip, TrayTip and return types to window functions Jul 17, 2020

yemreak added 3 commits July 17, 2020 15:11

👨‍💻 Code improvement

c9dea4c

📝 Documentation added & fixed

730933e

🤹‍♂️ Add more traytip methods

a0c18bb

yemreak commented Jul 17, 2020

View reviewed changes

yemreak mentioned this pull request Jul 17, 2020

Feature/GUI #11

Closed

22 tasks

📝 Added to README

1c5e317

Revert "👨‍💻 Added return types to window functions"

9308052

This reverts commit d3627ea.

yemreak requested a review from spyoungtech July 17, 2020 19:07

spyoungtech reviewed Jul 17, 2020

View reviewed changes

ahk/script.py Outdated Show resolved Hide resolved

yemreak commented Jul 17, 2020

View reviewed changes

ahk/autohotkey.py Show resolved Hide resolved

ahk/autohotkey.py Show resolved Hide resolved

ahk/autohotkey.py Show resolved Hide resolved

spyoungtech reviewed Jul 18, 2020

View reviewed changes

tests/unittests/test_gui.py Outdated Show resolved Hide resolved

Revert "👨‍💻 Code improvement"

c78e5bd

This reverts commit c9dea4c.

🎉 Unicode char support added spyoungtech#93 spyoungtech#45 spyoungtec…

ebbfcc2

…h#86

yemreak commented Jul 18, 2020

View reviewed changes

yemreak requested a review from spyoungtech July 22, 2020 19:35

spyoungtech merged commit a84798f into spyoungtech:master Sep 7, 2020

spyoungtech mentioned this pull request Sep 7, 2020

Please add the ToolTip and TrayTip function #40

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

➕ Added ToolTip, TrayTip and return types to window functions #92

➕ Added ToolTip, TrayTip and return types to window functions #92

yemreak commented Jul 16, 2020 •

edited

Loading

yemreak Jul 17, 2020

spyoungtech Jul 17, 2020 •

edited

Loading

yemreak Jul 18, 2020

yemreak Jul 18, 2020 •

edited

Loading

yemreak Jul 18, 2020

yemreak commented Jul 17, 2020

spyoungtech commented Jul 17, 2020 •

edited

Loading

yemreak commented Jul 17, 2020

yemreak commented Jul 18, 2020

yemreak Jul 18, 2020

yemreak Jul 18, 2020

yemreak Jul 18, 2020

yemreak Jul 18, 2020

yemreak commented Jul 18, 2020

yemreak commented Aug 23, 2020

spyoungtech commented Sep 2, 2020

spyoungtech commented Sep 7, 2020

spyoungtech commented Sep 7, 2020

		encoded_title = "% " + "".join([f"Chr({hex(ord(char))})" for char in title])
		encoded_text = "% " + "".join([f"Chr({hex(ord(char))})" for char in text])

		ahk._show_traytip("⽲ Normal 🚀", "It's me")
		ahk._show_traytip("🐌 Slow 🐌", "It's you", second=2)

➕ Added ToolTip, TrayTip and return types to window functions #92

➕ Added ToolTip, TrayTip and return types to window functions #92

Conversation

yemreak commented Jul 16, 2020 • edited Loading

yemreak Jul 17, 2020

Choose a reason for hiding this comment

spyoungtech Jul 17, 2020 • edited Loading

Choose a reason for hiding this comment

yemreak Jul 18, 2020

Choose a reason for hiding this comment

yemreak Jul 18, 2020 • edited Loading

Choose a reason for hiding this comment

yemreak Jul 18, 2020

Choose a reason for hiding this comment

yemreak commented Jul 17, 2020

spyoungtech commented Jul 17, 2020 • edited Loading

yemreak commented Jul 17, 2020

yemreak commented Jul 18, 2020

yemreak Jul 18, 2020

Choose a reason for hiding this comment

yemreak Jul 18, 2020

Choose a reason for hiding this comment

yemreak Jul 18, 2020

Choose a reason for hiding this comment

yemreak Jul 18, 2020

Choose a reason for hiding this comment

yemreak commented Jul 18, 2020

yemreak commented Aug 23, 2020

spyoungtech commented Sep 2, 2020

spyoungtech commented Sep 7, 2020

spyoungtech commented Sep 7, 2020

yemreak commented Jul 16, 2020 •

edited

Loading

spyoungtech Jul 17, 2020 •

edited

Loading

yemreak Jul 18, 2020 •

edited

Loading

spyoungtech commented Jul 17, 2020 •

edited

Loading