New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change `Decode`'s return type to `IReadOnlyList` #21

Merged

aradalvand merged 2 commits into main from decode-return-type

Sep 9, 2023

Collaborator

aradalvand commented Sep 9, 2023

This avoids the memory allocation that .ToArray() entailed.


          Change Decode's return type to IReadOnlyList

ddde467

This avoids the memory allocation that `.ToArray()` entailed.

aradalvand force-pushed the decode-return-type branch from 058c86f to ddde467 Compare

September 9, 2023 17:39


          Use ShouldBe instead of ShouldBeEquivalentTo in tests

be20919

`ShouldBeEquivalentTo` seems to fail to work as expected when the
collection types are different (e.g. `int[]` and `IReadOnlyList<int>`),
we should've actually always used `ShouldBe`:
https://docs.shouldly.org/documentation/equality/shouldbe#enumerables

aradalvand merged commit 83460d6 into main

1 check passed

aradalvand deleted the decode-return-type branch

September 10, 2023 12:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet