On Windows an Error Occurs When a --top-dir Option Contains Spaces

[NorthLarry]

On Windows an error occurs when a --top-dir option contains spaces. The result is similar to this:

sqitch --top-dir "C:\path\with some spaces" revert --target some_target -y
Reverting all changes from some_target
  - some_script .............. C:/path/with:  No such file or directory
not ok
"psql.exe" unexpectedly returned exit value 1

[theory]

Huh. Might be an issue with IPC::System::Simple, though I don't see this limitation in its Windows notes. @pjf, any ideas? Sqitch invokes runx here.

[theory]

Works for me when i make the path locally:

And also when I use a full path:

[theory]

Although maybe psql doesn't like it?

[NorthLarry]

Yes, it looked as though psql could not find a script on path with spaces or was provided an incomplete path..

[theory]

So, does this work for you?

psql -f "C:\path\with some spaces/deploy/some_script.sql"

If it doesn't, then it's psql's bug.

[NorthLarry]

Works for me. Psql version 9.6.3.

…

On Thu, Jul 13, 2017 at 2:22 PM, David E. Wheeler ***@***.***> wrote: So, does this work for you? psql -f "C:\path\with some spaces/deploy/some_script.sql" If it doesn't, then it's psql's bug. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#331 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMnDJ8p1FvezgCyOprh0K92lOsAQvnI5ks5sNm5-gaJpZM4NiUXw> .

-- Larry North Sr. Software Engineer www.conserviscorp.com [image: https://ci4.googleusercontent.com/proxy/4zmY--G5c0z75FEYFgj1NlVuZbXK9P4CIxWsW0uRNZqWwzHi8jTsHd7US2q8YfxdggLoMJ5RM20uO0-zP-PgPJGXLnyCS38wuFcFvA=s0-d-e1-ft#http://www.conserviscorp.com/images/signature_logo.png] <http://www.conserviscorp.com/>

[theory]

Hrm. How about

 perl -MIPC::System::Simple=runx -e "runx @ARGV" psql -f "C:\path\with some spaces/deploy/some_script.sql"

If that works, try replacing runx with capturex.

[NorthLarry]

runx does not work; problem with spaces. Replacing runx with capturex yields: Array found where operator expected at -e line 1, near "runx @argv" (Do you need to predeclare runx?) syntax error at -e line 1, near "runx @argv " Execution of -e aborted due to compilation errors.

…

On Thu, Jul 13, 2017 at 3:34 PM, David E. Wheeler ***@***.***> wrote: Hrm. How about perl -MIPC::System::Simple=runx -e "runx @argv" psql -f "C:\path\with some spaces/deploy/some_script.sql" If that works, try replacing runx with capturex. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#331 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMnDJ-9rKFBBBObH1RObBTN-P88vIP3pks5sNn8-gaJpZM4NiUXw> .

-- Larry North Sr. Software Engineer www.conserviscorp.com [image: https://ci4.googleusercontent.com/proxy/4zmY--G5c0z75FEYFgj1NlVuZbXK9P4CIxWsW0uRNZqWwzHi8jTsHd7US2q8YfxdggLoMJ5RM20uO0-zP-PgPJGXLnyCS38wuFcFvA=s0-d-e1-ft#http://www.conserviscorp.com/images/signature_logo.png] <http://www.conserviscorp.com/>

[theory]

Interesting. Can you try with some other app, maybe a Windows standard app like Notepad or something?

perl -MIPC::System::Simple=runx -e "runx @ARGV" notepad "C:\path\with some spaces/deploy/some_script.sql"

[pjf]

There's indeed a chance this is an IPC::System::Simple issue, in which case yes, I should definitely be fixing it. :)

Alas I don't have easy access to a Windows testing environment, so patches may be even more welcome than usual. :)

[NorthLarry]

The notepad test works. I know almost nothing about Perl, so I won't be able to help with patches. I think Docker has Windows containers. Maybe you could use that for a Windows testing environment.

…

On Thu, Jul 13, 2017 at 11:35 PM, Paul Fenwick ***@***.***> wrote: There's indeed a chance this is an IPC::System::Simple issue, in which case yes, I should definitely be fixing it. :) Alas I don't have easy access to a Windows testing environment, so patches may be even more welcome than usual. :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#331 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMnDJ3muglTdGHliOORF85xnJ_Bp0-Rsks5sNvAjgaJpZM4NiUXw> .

-- Larry North Sr. Software Engineer www.conserviscorp.com [image: https://ci4.googleusercontent.com/proxy/4zmY--G5c0z75FEYFgj1NlVuZbXK9P4CIxWsW0uRNZqWwzHi8jTsHd7US2q8YfxdggLoMJ5RM20uO0-zP-PgPJGXLnyCS38wuFcFvA=s0-d-e1-ft#http://www.conserviscorp.com/images/signature_logo.png] <http://www.conserviscorp.com/>

[theory]

Yeah, I have used the Free Windows VMs to do my Windows testing. Fire one up, use IE to download Strawberry Perl, install it and go. I'll open a bug in your issue tracker for now, @pjf.

[theory]

Curious that the Notepad example worked. Might be harder for @pjf to replicate then without installing Windows Postgres. There are installers, though.