Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Incorrect documentation / use of thresh.pc argument #752

Closed
ATpoint opened this issue Jan 24, 2024 · 2 comments
Closed

Incorrect documentation / use of thresh.pc argument #752

ATpoint opened this issue Jan 24, 2024 · 2 comments

Comments

@ATpoint
Copy link

ATpoint commented Jan 24, 2024

Hello,

in ?identifyOverExpressedGenes() it says that for thresh.pc Threshold of the percent of cells expressed in one cluster. However, in the code on multiple occasions such as https://github.com/jinworks/CellChat/blob/main/R/utilities.R#L374 you multiply this by 100, suggesting that either the "*100" needs to be removed everywhere or documentation must state that the argument takes the a fraction rather than percentage.

best wishes!

@ATpoint
Copy link
Author

ATpoint commented Jan 24, 2024

sorry, wrong repo, will post in v2

@ATpoint
Copy link
Author

ATpoint commented Jan 24, 2024

@sqjin I suggest you make this repository an archive. It's so easy to mix up this one and the new v2. Archiving it will make it clear immediately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant