Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for es module and browser-only environment #539

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Jan 2, 2023

  1. Configuration menu
    Copy the full SHA
    e9bcc46 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5772548 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5aad0da View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. browser/module: fix statement binding

    This was tricky to figure out. Using the ENVIRONMENT=web flag for the browser
    build started causing prepared statements to fail - it would behave as if
    no params were passed to db.exec("...", []) as the second arg.
    
    It turns out that the closure compiler was removing the bind() call..
    
    It's not clear to me why, but adding externs that map out the exported
    structure fixes the issue.
    
    Some other notes:
    - emscripten runs with ADVANCED mode for closure compiler
    - closure compiler reuses variables...
    - use --closure-args=--debug and --closure-args=--pretty-print for clues
    stephen committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    7aad773 View commit details
    Browse the repository at this point in the history