Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We've been using your caching framework for some time now and we've discovered an issue where the decorators
@cache_on_arguments
(and@cache_multi_on_arguments
) don't preserve the signatures of the decorated functions. An example:To remedy this, I'm submitting a PR that uses the decorator module to preserve the signature of functions decorated by
cache_on_arguments
.I've also added tests to check this behavior.
I wasn't sure where to put a new dependency, so I put it in setup.py under
install_requires
. Let me know if there's a better place for itThanks!