Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`wrap` argument (ProxyBackend) does not work on cache_from_config #41

Closed
sqlalchemy-bot opened this issue Sep 11, 2013 · 4 comments
Closed
Labels
bug

Comments

@sqlalchemy-bot
Copy link

@sqlalchemy-bot sqlalchemy-bot commented Sep 11, 2013

Migrated issue, originally created by jvanasco (jvanasco)

It appears that the settings in ( file = dogpile.cache.region.py CacheRegion.configure() are not synched with CacheRegion.configure_from_config()

editing line 344 to reflect the following makes it work:

    -   _config_prefix="%sarguments." % prefix
    +   _config_prefix="%sarguments." % prefix ,
    +    wrap = config_dict.get(
    +                        "%swrap" % prefix, None),

This wouldn't come up if you were building the regions entirely off a config file, but if you're using a dict to track multiple regions, this creates an issue.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Sep 12, 2013

Morgan Fainberg () wrote:

A temporary fix would be to just call region.wrap(proxy) where needed. But I agree, this would be a nice improvement to the dict configuration mechanism.

You should issue a pull request with the change!

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Dec 5, 2014

Michael Bayer (zzzeek) wrote:

  • 0.5.5
  • changelog for #41, fixes #41

345d07d

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Dec 5, 2014

Changes by Michael Bayer (zzzeek):

  • changed status to closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant