-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix column __init__ args typing for EventSchemaTarget #73
Merged
CaselIT
merged 8 commits into
sqlalchemy:master
from
MaicoTimmerman:column-foreign-key-init
Apr 29, 2021
Merged
Fix column __init__ args typing for EventSchemaTarget #73
CaselIT
merged 8 commits into
sqlalchemy:master
from
MaicoTimmerman:column-foreign-key-init
Apr 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validated with |
bryanforbes
reviewed
Apr 23, 2021
bryanforbes
reviewed
Apr 23, 2021
MaicoTimmerman
force-pushed
the
column-foreign-key-init
branch
from
April 29, 2021 14:59
8d28eaa
to
7a4ca1b
Compare
bryanforbes
reviewed
Apr 29, 2021
sqlalchemy-stubs/sql/elements.pyi
Outdated
@@ -425,6 +425,7 @@ class ColumnClause( | |||
roles.StrAsPlainColumnRole, | |||
Immutable, | |||
NamedColumn, | |||
Generic[_TE], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taken care of in #37
# Conflicts: # sqlalchemy-stubs/sql/elements.pyi
CaselIT
approved these changes
Apr 29, 2021
This was referenced Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
Column.__init__
for*args
Checklist
Test-case:
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!