Enhance sqlpath.Glob
to actually support glob wildcard
#2955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
Glob
function in theinternal/sqlpath
package to support glob patterns in the input paths. It also adds comprehensive tests for theGlob
function, ensuring its correct behavior and in various scenarios, as well as protects it from regressions.Problem
I want
sqlc
to be able to collect queries from different modules of my applications:Epected:
Normal execution.
Actual:
internal/sql/sqlpath/read_test.go
: Introduced a new test file with multiple test cases for the Glob function. These tests cover various scenarios like handling of SQL files, non-SQL files, hidden files, non-existent paths, unreadable directories, and symlinks.internal/sql/sqlpath/read.go
: Added a new functionexpandGlob
s to expand glob patterns in the input paths. TheGlob
function now callsexpandGlob
s before processing the paths. Also, added error handling for cases where the path does not exist or is not a file.internal/sql/sqlpath/testdata/
: Dummy directory of files and symlinks to test various scenarios.