Skip to content

Commit 74851f6

Browse files
author
drh
committed
Fix the SQLITE_ALLOW_ROWID_IN_VIEW bug-compatibility option so that it works
again. Add the SQLITE_CONFIG_ROWID_IN_VIEW sqlite3_config() value to optionally disable the bug-compatibility mode at start-time. Enable testing of SQLITE_ALLOW_ROWID_IN_VIEW. FossilOrigin-Name: 7a3d0027f81e8def49e2a665c9202b966c37f066b1298476e4d7d72e56323f85
1 parent 84fa240 commit 74851f6

23 files changed

+287
-88
lines changed

manifest

Lines changed: 29 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
C Fix\sa\sassert()\sthat\sis\sincorrect,\sthough\sharmless.\s\sAlso\sadd\sa\stest\scase.
2-
D 2024-03-21T22:12:45.346
1+
C Fix\sthe\sSQLITE_ALLOW_ROWID_IN_VIEW\sbug-compatibility\soption\sso\sthat\sit\sworks\nagain.\sAdd\sthe\sSQLITE_CONFIG_ROWID_IN_VIEW\ssqlite3_config()\svalue\sto\noptionally\sdisable\sthe\sbug-compatibility\smode\sat\sstart-time.\nEnable\stesting\sof\sSQLITE_ALLOW_ROWID_IN_VIEW.
2+
D 2024-03-24T19:08:05.017
33
F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
44
F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
55
F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -680,19 +680,19 @@ F src/btmutex.c 79a43670447eacc651519a429f6ece9fd638563cf95b469d6891185ddae2b522
680680
F src/btree.c 5410768087e524f331816c751c4b1f714693fa864a448337e443e49cc397aeaf
681681
F src/btree.h 03e3356f5208bcab8eed4e094240fdac4a7f9f5ddf5e91045ce589f67d47c240
682682
F src/btreeInt.h 3e2589726c4f105e653461814f65857465da68be1fac688de340c43b873f4062
683-
F src/build.c e7d9044592eeeea8e78d8ae53ca8d31fd6e92ca0d4f53e2f2e8ccf7352e0b04b
683+
F src/build.c ec93d135f9c02b2a5d174384b6f9c222c16b1c8e473c482284759f3f0a35e336
684684
F src/callback.c db3a45e376deff6a16c0058163fe0ae2b73a2945f3f408ca32cf74960b28d490
685685
F src/complete.c a3634ab1e687055cd002e11b8f43eb75c17da23e
686-
F src/ctime.c 23331529e654be40ca97d171cbbffe9b3d4c71cc53b78fe5501230675952da8b
686+
F src/ctime.c 64e4b1227b4ed123146f0aa2989131d1fbd9b927b11e80c9d58c6a68f9cd5ce3
687687
F src/date.c 3b8d02977d160e128469de38493b4085f7c5cf4073193459909a6af3cf6d7c91
688688
F src/dbpage.c 80e46e1df623ec40486da7a5086cb723b0275a6e2a7b01d9f9b5da0f04ba2782
689689
F src/dbstat.c 3b677254d512fcafd4d0b341bf267b38b235ccfddbef24f9154e19360fa22e43
690690
F src/delete.c cb766727c78e715f9fb7ec8a7d03658ed2a3016343ca687acfcec9083cdca500
691-
F src/expr.c 2b8496acec9b40cedcbb31c3b0d6cb797359eec10a73840e925de7cab06c99a9
691+
F src/expr.c 1fece60622b8b74d8b3bf59faba4c2509a177ea65d9642dfbd22ceb7ec6eeea5
692692
F src/fault.c 460f3e55994363812d9d60844b2a6de88826e007
693693
F src/fkey.c a47610f0a5c6cb0ad79f8fcef039c01833dec0c751bb695f28dc0ec6a4c3ba00
694694
F src/func.c 283d4f3b2751a1d9339fd93a8a013d1948fd5f4474a3cab0955eb4fafd445d0f
695-
F src/global.c 765a0656d6cbf043cb272ff0ae38f39cc46713539ffe6793258ed3eb4b188b52
695+
F src/global.c 61a419dd9e993b9be0f91de4c4ccf322b053eb829868e089f0321dd669be3b90
696696
F src/hash.c 9ee4269fb1d6632a6fecfb9479c93a1f29271bddbbaf215dd60420bcb80c7220
697697
F src/hash.h 3340ab6e1d13e725571d7cee6d3e3135f0779a7d8e76a9ce0a85971fa3953c51
698698
F src/hwtime.h f9c2dfb84dce7acf95ce6d289e46f5f9d3d1afd328e53da8f8e9008e3b3caae6
@@ -701,7 +701,7 @@ F src/insert.c eb33ea46dcab93e90f112fced343aaf41f59cbd2e951d5066f1f9302be1c2f34
701701
F src/json.c 29a42bc92c2384653b8b5e5ad26bdee4e2334544c7cfb78ceb4a3ca81d674686
702702
F src/legacy.c d7874bc885906868cd51e6c2156698f2754f02d9eee1bae2d687323c3ca8e5aa
703703
F src/loadext.c 7432c944ff197046d67a1207790a1b13eec4548c85a9457eb0896bb3641dfb36
704-
F src/main.c 438b95162acfa17b7d218f586f5bde11d6ae82bcf030c9611fc537556870ad6b
704+
F src/main.c 8a59d297ec77e6b78550433bfccb95a1b26f2fb69aaaf233206e21579a1cfcc1
705705
F src/malloc.c f016922435dc7d1f1f5083a03338a3e91f8c67ce2c5bdcfa4cdef62e612f5fcc
706706
F src/mem0.c 6a55ebe57c46ca1a7d98da93aaa07f99f1059645
707707
F src/mem1.c 3bb59158c38e05f6270e761a9f435bf19827a264c13d1631c58b84bdc96d73b2
@@ -736,14 +736,14 @@ F src/pragma.h e690a356c18e98414d2e870ea791c1be1545a714ba623719deb63f7f226d8bb7
736736
F src/prepare.c 371f6115cb69286ebc12c6f2d7511279c2e47d9f54f475d46a554d687a3b312c
737737
F src/printf.c d3392b2a20ee314ddeef34fb43c904bf4619eb20ff9a9e07e3950a7e4dcd6912
738738
F src/random.c 606b00941a1d7dd09c381d3279a058d771f406c5213c9932bbd93d5587be4b9c
739-
F src/resolve.c 446bcb8ebf0ea7066c2ca99e5336f0dbc9230ac76f80fafd1bfa82fe7871af2d
739+
F src/resolve.c b81374797e47a2e98c2a10b7152ad70280dfeb228f26ac45470760d02e360318
740740
F src/rowset.c 8432130e6c344b3401a8874c3cb49fefe6873fec593294de077afea2dce5ec97
741-
F src/select.c f1a81ff4f8e9e76c224e2ab3a4baa799add0db22158c7fcede65d8cc4a6fa2da
742-
F src/shell.c.in f7cc8711aee604bc078a93d777ad7246980485c57fa3047408b0f842ba03c14d
743-
F src/sqlite.h.in 020d7b7307dda51420dc48b47e5334eaface77baba6bd9818375d392eb3ab5b5
741+
F src/select.c 8b9b78a58781955d5bc676efde95e3cbc82174bf7c1b3968c855faff134c24d2
742+
F src/shell.c.in e4815eb8a7b3110994a1d7e9f42e6b3e9e3576d25ec63f75259b797938cada98
743+
F src/sqlite.h.in 4f7840e1abb041b80da0af48f870e2ae3552e2a97c902eebe7455fe5a89562e3
744744
F src/sqlite3.rc 5121c9e10c3964d5755191c80dd1180c122fc3a8
745745
F src/sqlite3ext.h 3f046c04ea3595d6bfda99b781926b17e672fd6d27da2ba6d8d8fc39981dcb54
746-
F src/sqliteInt.h 2e75c267e37e3a5ee91a433b2e9d04ab5ece121dde71e3981727e9ec574b5473
746+
F src/sqliteInt.h 867a6691a5f06ceb6a17a828337f6ace1ad35c44f324bf50d4a2169c3db8571f
747747
F src/sqliteLimit.h 6878ab64bdeb8c24a1d762d45635e34b96da21132179023338c93f820eee6728
748748
F src/status.c cb11f8589a6912af2da3bb1ec509a94dd8ef27df4d4c1a97e0bcf2309ece972b
749749
F src/table.c 0f141b58a16de7e2fbe81c308379e7279f4c6b50eb08efeec5892794a0ba30d1
@@ -762,7 +762,7 @@ F src/test_backup.c bf5da90c9926df0a4b941f2d92825a01bbe090a0
762762
F src/test_bestindex.c f6af1e41cb7901edafb065a8198e4a0192dd42432b642d038965be5e628dec12
763763
F src/test_blob.c ae4a0620b478548afb67963095a7417cd06a4ec0a56adb453542203bfdcb31ce
764764
F src/test_btree.c 8b2dc8b8848cf3a4db93f11578f075e82252a274
765-
F src/test_config.c f0cc1f517deaa96dd384822ae2bb91534fa56aa458528b439830d709941d3932
765+
F src/test_config.c 5fa77ee6064ba546e144c4fea870c5ede2c54314616f81485c6a9c4192100c75
766766
F src/test_delete.c e2fe07646dff6300b48d49b2fee2fe192ed389e834dd635e3b3bac0ce0bf9f8f
767767
F src/test_demovfs.c 38a459d1c78fd9afa770445b224c485e079018d6ac07332ff9bd07b54d2b8ce9
768768
F src/test_devsym.c 649434ed34d0b03fbd5a6b42df80f0f9a7e53f94dd1710aad5dd8831e91c4e86
@@ -1244,7 +1244,7 @@ F test/fuzzdata8.db 4a53b6d077c6a5c23b609d8d3ac66996fa55ba3f8d02f9b6efdd0214a767
12441244
F test/fuzzer1.test 3d4c4b7e547aba5e5511a2991e3e3d07166cfbb8
12451245
F test/fuzzer2.test a85ef814ce071293bce1ad8dffa217cbbaad4c14
12461246
F test/fuzzerfault.test f64c4aef4c9e9edf1d6dc0d3f1e65dcc81e67c996403c88d14f09b74807a42bc
1247-
F test/fuzzinvariants.c b34530e8431f2cf3591eff588fc7684d6fdef466916fb46141c8c5374a3d8099
1247+
F test/fuzzinvariants.c 4355043e98cd8555c62462fcbba91c17c6492b0b017bbbe68656d5f2208f6444
12481248
F test/gcfault.test 4ea410ac161e685f17b19e1f606f58514a2850e806c65b846d05f60d436c5b0d
12491249
F test/gencol1.test e169bdfa11c7ed5e9f322a98a7db3afe9e66235750b68c923efee8e1876b46ec
12501250
F test/genesis.tcl 1e2e2e8e5cc4058549a154ff1892fe5c9de19f98
@@ -1313,7 +1313,7 @@ F test/join.test f7abfef3faeaf2800308872e33a57e5b6e4a2b44fb8c6b90c6068412e71a6cf
13131313
F test/join2.test 8561fe82ce434ac96de91544072e578dc2cadddf2d9bc9cd802f866a9b92502e
13141314
F test/join3.test 6f0c774ff1ba0489e6c88a3e77b9d3528fb4fda0
13151315
F test/join4.test 1a352e4e267114444c29266ce79e941af5885916
1316-
F test/join5.test 7cc3f3595bb41e60f3f96d5cb6dd8cfcbc31212f0136bba6fc081c082994a94a
1316+
F test/join5.test 380d12a9350f99f0cc681a4f1fea999886f18b3fe0d71a9b3065bcaead1e007f
13171317
F test/join6.test f809c025fa253f9e150c0e9afd4cef8813257bceeb6f46e04041228c9403cc2c
13181318
F test/join7.test 2268dcbb54b724391dda3748ea95c60d960607ffeed67885675998e7117697f6
13191319
F test/join8.test d384d63985e3991c404afccadaf3efd1cdf9cd72680167f80e3cb80b95c18c68
@@ -1324,7 +1324,7 @@ F test/joinC.test 1f1a602c2127f55f136e2cbd3bf2d26546614bf8cffe5902ec1ac9c07f87f2
13241324
F test/joinD.test 2ce62e7353a0702ca5e70008faf319c1d4686aa19fba34275c6d1da0e960be28
13251325
F test/joinE.test d5d182f3812771e2c0d97c9dcf5dbe4c41c8e21c82560e59358731c4a3981d6b
13261326
F test/joinF.test 53dd66158806823ea680dd7543b5406af151b5aafa5cd06a7f3231cd94938127
1327-
F test/joinH.test f69e5b53b7d887914e854b6a131efbed4ea9f5ca52bdab81788bfc3e79299f43
1327+
F test/joinH.test d5054173442fdf98260eeb6bb9751daa733b0ae6842fe50dcbd5469945b86985
13281328
F test/journal1.test c7b768041b7f494471531e17abc2f4f5ebf9e5096984f43ed17c4eb80ba34497
13291329
F test/journal2.test 9dac6b4ba0ca79c3b21446bbae993a462c2397c4
13301330
F test/journal3.test 7c3cf23ffc77db06601c1fcfc9743de8441cb77db9d1aa931863d94f5ffa140e
@@ -1409,13 +1409,13 @@ F test/minmax2.test cf9311babb6f0518d04e42fd6a42c619531c4309a9dd790a2c4e9b3bc595
14091409
F test/minmax3.test cc1e8b010136db0d01a6f2a29ba5a9f321034354
14101410
F test/minmax4.test 272ca395257f05937dc96441c9dde4bc9fbf116a8d4fa02baeb0d13d50e36c87
14111411
F test/misc1.test 8d138a4926ab90617c1aa29ce26e7785ae2b83a4d3a195d543b7374e05589dd1
1412-
F test/misc2.test 71e746af479119386ac2ed7ab7d81d99970e75b49ffd3e8efffee100b4b5f350
1412+
F test/misc2.test a1a3573cc02662becd967766021d6f16c54684d56df5f227481c7ef0d9df0bd0
14131413
F test/misc3.test cf3dda47d5dda3e53fc5804a100d3c82be736c9d
14141414
F test/misc4.test 10cd6addb2fa9093df4751a1b92b50440175dd5468a6ec84d0386e78f087db0e
14151415
F test/misc5.test c4aeaa0fa28faa08f2485309c38db4719e6cd1364215d5687a5b96d340a3fa58
14161416
F test/misc6.test 953cc693924d88e6117aeba16f46f0bf5abede91
14171417
F test/misc7.test d912f3d45c2989191b797504a220ca225d6be80b21acad22ba0d35f4a9ee4579
1418-
F test/misc8.test 4db9f8be59834cea08c87e9658014080efa02678ef54a088f84fa5647e81fee0
1418+
F test/misc8.test 08d2380bc435486b12161521f225043ac2be26f02471c2c1ea4cac0b1548edbd
14191419
F test/misuse.test 9e7f78402005e833af71dcab32d048003869eca5abcaccc985d4f8dc1d86bcc7
14201420
F test/mjournal.test 28a08d5cb5fb5b5702a46e19176e45e964e0800d1f894677169e79f34030e152
14211421
F test/mmap1.test 18de3fd7b70a777af6004ca2feecfcdd3d0be17fa04058e808baf530c94b1a1d
@@ -1509,15 +1509,15 @@ F test/regexp2.test 55ed41da802b0e284ac7e2fe944be3948f93ff25abbca0361a609acfed13
15091509
F test/reindex.test cd9d6021729910ece82267b4f5e1b5ac2911a7566c43b43c176a6a4732e2118d
15101510
F test/resetdb.test 54c06f18bc832ac6d6319e5ab23d5c8dd49fdbeec7c696d791682a8006bd5fc3
15111511
F test/resolver01.test f4022acafda7f4d40eca94dbf16bc5fc4ac30ceb
1512-
F test/returning1.test db532cde29d6aebbc48c6ddc3149b30476f8e69ca7a2c4b53986c7635e6fd8ec
1512+
F test/returning1.test 3ead782eddf51f573cdd43bcbb10d1b485ac095a19a76d16c43fd159ea9b7466
15131513
F test/returningfault.test ae4c4b5e8745813287a359d9ccdb9d5c883c2e68afb18fb0767937d5de5692a4
15141514
F test/rollback.test 06680159bc6746d0f26276e339e3ae2f951c64812468308838e0a3362d911eaa
15151515
F test/rollback2.test 3f3a4e20401825017df7e7671e9f31b6de5fae5620c2b9b49917f52f8c160a8f
15161516
F test/rollbackfault.test 0e646aeab8840c399cfbfa43daab46fd609cf04a
15171517
F test/round1.test 29c3c9039936ed024d672f003c4d35ee11c14c0acb75c5f7d6188ff16190cfd4
15181518
F test/rowallock.test 3f88ec6819489d0b2341c7a7528ae17c053ab7cc
15191519
F test/rowhash.test 0bc1d31415e4575d10cacf31e1a66b5cc0f8be81
1520-
F test/rowid.test e29025be95baf6b32f0d5edef59a7633028325896a98f1caa8019559ca910350
1520+
F test/rowid.test d27191b5ce794c05bf61081e8b2c546a1844c1641321dcaf7fb785234256cc8e
15211521
F test/rowvalue.test baf4fa3ec1a8c1c920c3faa5fd25959cb454bbd99ac8960397c34549d9fc4abe
15221522
F test/rowvalue2.test 060d238b7e5639a7c5630cb5e63e311b44efef2b
15231523
F test/rowvalue3.test 1347e25ca11c547c5a6ff0cc5626f95aa9740e9275bfaec096029f57cb2130ce
@@ -1849,7 +1849,7 @@ F test/trigger5.test 619391a3e9fc194081d22cefd830d811e7badf83
18491849
F test/trigger6.test 0e411654f122552da6590f0b4e6f781048a4a9b9
18501850
F test/trigger7.test e7ce54bfda67a88d778aea42544e151c465547a7e617127b6914c2221a6d53c1
18511851
F test/trigger8.test 30cb0530bd7c4728055420e3f739aa00412eafa4
1852-
F test/trigger9.test fd49aff8b724ae1a6238989ecf84320d88c0e8f8d9142a891b93f826dfe37b59
1852+
F test/trigger9.test 1724b595661da3dd3c8d79f0ebae818132a39e65c241bad2049f66952b1dc29d
18531853
F test/triggerA.test 837be862d8721f903dba3f3ceff05b32e0bee5214cf6ea3da5fadf12d3650e9d
18541854
F test/triggerB.test 56780c031b454abac2340dbb3b71ac5c56c3d7fe
18551855
F test/triggerC.test 29f5a28d0fe39e6e2c01f6e1f53f08c0955170ae10a63ad023e33cb0a1682a51
@@ -1869,7 +1869,7 @@ F test/types.test bf816ce73c7dfcfe26b700c19f97ef4050d194ff
18691869
F test/types2.test 1aeb81976841a91eef292723649b5c4fe3bc3cac
18701870
F test/types3.test c9db8f9e80309edfa4252585cf16bcab7ed31f39eeb904d21e831199a3613fb0
18711871
F test/unhex.test b7f1b806207cb77fa31c3e434fe92fba524464e3e9356809bfcc28f15af1a8b7
1872-
F test/unionall.test 5b1c4186a661e4bf762875caf4c61d8fda3dd04a6fa9005187f6ba8900c2913f
1872+
F test/unionall.test 04d30726c5056f84f92b3a12bf8d8a1dbbe807d1ddc8af95def09e6ef2dd91e3
18731873
F test/unionall2.test 71e8fa08d5699d50dc9f9dc0c9799c2e7a6bb7931a330d369307a4df7f157fa1
18741874
F test/unionallfault.test 652bfbb630e6c43135965dc1e8f0a9a791da83aec885d626a632fe1909c56f73
18751875
F test/unionvtab.test e1704ab1b4c1bb3ffc9da4681f8e85a0b909fd80b937984fc94b27415ac8e5a4
@@ -2080,7 +2080,7 @@ F tool/max-limits.c cbb635fbb37ae4d05f240bfb5b5270bb63c54439
20802080
F tool/merge-test.tcl de76b62f2de2a92d4c1ca4f976bce0aea6899e0229e250479b229b2a1914b176
20812081
F tool/mkautoconfamal.sh cbdcf993fa83dccbef7fb77b39cdeb31ef9f77d9d88c9e343b58d35ca3898a6a
20822082
F tool/mkccode.tcl 86463e68ce9c15d3041610fedd285ce32a5cf7a58fc88b3202b8b76837650dbe x
2083-
F tool/mkctimec.tcl a16682eae5f01f85e5861b2aa215ca0d46b4230658ee25977e02b4508566fb75 x
2083+
F tool/mkctimec.tcl 060e9785e9503bf51f8b1b11b542bdeef90fd0ceb0738154f6762acec0c61e5f x
20842084
F tool/mkkeywordhash.c b9faa0ae7e14e4dbbcd951cddd786bf46b8a65bb07b129ba8c0cfade723aaffd
20852085
F tool/mkmsvcmin.tcl 8897d515ef7f94772322db95a3b6fce6c614d84fe0bdd06ba5a1c786351d5a1d
20862086
F tool/mkopcodec.tcl 33d20791e191df43209b77d37f0ff0904620b28465cca6990cf8d60da61a07ef
@@ -2160,9 +2160,11 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
21602160
F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
21612161
F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
21622162
F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
2163-
P 8af5878138f30515c0d4031cb4450a1b6f96a023a8f2dd5e6591a1096b1ecaa6
2164-
Q +57b0c984605d0f437b4930f6b994e15b80340c753d46a679b07d356c645856ea
2165-
R b24cd64eb6eb2f2c189b87d484db7a39
2163+
P 90537ce044c50ecca35920ecb27c7fb07d535be828ea943416c4633008d360b9
2164+
Q +66c69e2f20f7692e0f34743ae97b09c4d8d11b874cdc5381795f2d1e0410f724
2165+
Q +80c4223098c1827ff3a564f1f9a4203164a943e9a83eef99df68378fa3c4764b
2166+
Q +b6802565df0f63286a7ef26c92d3ed817895f244920a24909cd855090fdfa08c
2167+
R 0d09d8f09325e76c0e4cf2b8de81371b
21662168
U drh
2167-
Z 645227f5a09cdf219a892b679bb1a749
2169+
Z 7bf2d0ce1002104d5c73b77198b0a107
21682170
# Remove this line to create a well-formed Fossil manifest.

manifest.uuid

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
90537ce044c50ecca35920ecb27c7fb07d535be828ea943416c4633008d360b9
1+
7a3d0027f81e8def49e2a665c9202b966c37f066b1298476e4d7d72e56323f85

src/build.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3006,9 +3006,12 @@ void sqlite3CreateView(
30063006
** on a view, even though views do not have rowids. The following flag
30073007
** setting fixes this problem. But the fix can be disabled by compiling
30083008
** with -DSQLITE_ALLOW_ROWID_IN_VIEW in case there are legacy apps that
3009-
** depend upon the old buggy behavior. */
3010-
#ifndef SQLITE_ALLOW_ROWID_IN_VIEW
3011-
p->tabFlags |= TF_NoVisibleRowid;
3009+
** depend upon the old buggy behavior. The ability can also be toggled
3010+
** using sqlite3_config(SQLITE_CONFIG_ROWID_IN_VIEW,...) */
3011+
#ifdef SQLITE_ALLOW_ROWID_IN_VIEW
3012+
p->tabFlags |= sqlite3Config.mNoVisibleRowid; /* Optional. Allow by default */
3013+
#else
3014+
p->tabFlags |= TF_NoVisibleRowid; /* Never allow rowid in view */
30123015
#endif
30133016

30143017
sqlite3TwoPartName(pParse, pName1, pName2, &pName);

src/ctime.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ static const char * const sqlite3azCompileOpt[] = {
6565
"ALLOW_COVERING_INDEX_SCAN=" CTIMEOPT_VAL(SQLITE_ALLOW_COVERING_INDEX_SCAN),
6666
# endif
6767
#endif
68+
#ifdef SQLITE_ALLOW_ROWID_IN_VIEW
69+
"ALLOW_ROWID_IN_VIEW",
70+
#endif
6871
#ifdef SQLITE_ALLOW_URI_AUTHORITY
6972
"ALLOW_URI_AUTHORITY",
7073
#endif

src/expr.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2740,9 +2740,12 @@ int sqlite3ExprCanBeNull(const Expr *p){
27402740
return 0;
27412741
case TK_COLUMN:
27422742
assert( ExprUseYTab(p) );
2743-
return ExprHasProperty(p, EP_CanBeNull) ||
2744-
NEVER(p->y.pTab==0) || /* Reference to column of index on expr */
2745-
(p->iColumn>=0
2743+
return ExprHasProperty(p, EP_CanBeNull)
2744+
|| NEVER(p->y.pTab==0) /* Reference to column of index on expr */
2745+
#ifdef SQLITE_ALLOW_ROWID_IN_VIEW
2746+
|| (p->iColumn==XN_ROWID && IsView(p->y.pTab))
2747+
#endif
2748+
|| (p->iColumn>=0
27462749
&& p->y.pTab->aCol!=0 /* Possible due to prior error */
27472750
&& ALWAYS(p->iColumn<p->y.pTab->nCol)
27482751
&& p->y.pTab->aCol[p->iColumn].notNull==0);

src/global.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,9 @@ SQLITE_WSD struct Sqlite3Config sqlite3Config = {
288288
#endif
289289
#ifndef SQLITE_UNTESTABLE
290290
0, /* xTestCallback */
291+
#endif
292+
#ifdef SQLITE_ALLOW_ROWID_IN_VIEW
293+
0, /* mNoVisibleRowid. 0 == allow rowid-in-view */
291294
#endif
292295
0, /* bLocaltimeFault */
293296
0, /* xAltLocaltime */

src/main.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -765,6 +765,18 @@ int sqlite3_config(int op, ...){
765765
}
766766
#endif /* SQLITE_OMIT_DESERIALIZE */
767767

768+
case SQLITE_CONFIG_ROWID_IN_VIEW: {
769+
int *pVal = va_arg(ap,int*);
770+
#ifdef SQLITE_ALLOW_ROWID_IN_VIEW
771+
if( 0==*pVal ) sqlite3GlobalConfig.mNoVisibleRowid = TF_NoVisibleRowid;
772+
if( 1==*pVal ) sqlite3GlobalConfig.mNoVisibleRowid = 0;
773+
*pVal = (sqlite3GlobalConfig.mNoVisibleRowid==0);
774+
#else
775+
*pVal = 0;
776+
#endif
777+
break;
778+
}
779+
768780
default: {
769781
rc = SQLITE_ERROR;
770782
break;

src/resolve.c

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,8 +468,37 @@ static int lookupName(
468468
}
469469
}
470470
if( 0==cnt && VisibleRowid(pTab) ){
471+
/* pTab is a potential ROWID match. Keep track of it and match
472+
** the ROWID later if that seems appropriate. (Search for "cntTab"
473+
** to find related code.) Only allow a ROWID match if there is
474+
** a single ROWID match candidate.
475+
*/
476+
#ifdef SQLITE_ALLOW_ROWID_IN_VIEW
477+
/* In SQLITE_ALLOW_ROWID_IN_VIEW mode, allow a ROWID match
478+
** if there is a single VIEW candidate or if there is a single
479+
** non-VIEW candidate plus multiple VIEW candidates. In other
480+
** words non-VIEW candidate terms take precedence over VIEWs.
481+
*/
482+
if( cntTab==0
483+
|| (cntTab==1
484+
&& ALWAYS(pMatch!=0)
485+
&& ALWAYS(pMatch->pTab!=0)
486+
&& (pMatch->pTab->tabFlags & TF_Ephemeral)!=0
487+
&& (pTab->tabFlags & TF_Ephemeral)==0)
488+
){
489+
cntTab = 1;
490+
pMatch = pItem;
491+
}else{
492+
cntTab++;
493+
}
494+
#else
495+
/* The (much more common) non-SQLITE_ALLOW_ROWID_IN_VIEW case is
496+
** simpler since we require exactly one candidate, which will
497+
** always be a non-VIEW
498+
*/
471499
cntTab++;
472500
pMatch = pItem;
501+
#endif
473502
}
474503
}
475504
if( pMatch ){
@@ -595,13 +624,13 @@ static int lookupName(
595624
** Perhaps the name is a reference to the ROWID
596625
*/
597626
if( cnt==0
598-
&& cntTab==1
627+
&& cntTab>=1
599628
&& pMatch
600629
&& (pNC->ncFlags & (NC_IdxExpr|NC_GenCol))==0
601630
&& sqlite3IsRowid(zCol)
602631
&& ALWAYS(VisibleRowid(pMatch->pTab) || pMatch->fg.isNestedFrom)
603632
){
604-
cnt = 1;
633+
cnt = cntTab;
605634
if( pMatch->fg.isNestedFrom==0 ) pExpr->iColumn = -1;
606635
pExpr->affExpr = SQLITE_AFF_INTEGER;
607636
}

0 commit comments

Comments
 (0)