Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.11.1 - outstanding pieces #1747

Closed
12 of 13 tasks
justinclift opened this issue Feb 16, 2019 · 12 comments
Closed
12 of 13 tasks

3.11.1 - outstanding pieces #1747

justinclift opened this issue Feb 16, 2019 · 12 comments
Milestone

Comments

@justinclift
Copy link
Member

justinclift commented Feb 16, 2019

Building new release binaries right now. 😄

@justinclift justinclift added this to the 3.11.1 milestone Feb 16, 2019
@justinclift justinclift added the release blocker Bugs that are serious enough to block our next release label Feb 16, 2019
@justinclift justinclift pinned this issue Feb 16, 2019
@mgrojo
Copy link
Member

mgrojo commented Feb 16, 2019

Should we just release 3.11.1 "as is" and update the Release Notes to say we don't yet support Dark Mode at all?

In Linux, it works like a charm 😉 but yes I agree on releasing as is and publicize that it is not yet supported in Windows and Mac.

I think there are other bug fixes that we could consider for including in v3.11.1 if they are simple enough, for example, after making a quick review:
7e549c7
1925ccf
0ffed5e
79ffd77
58f52f1

@justinclift
Copy link
Member Author

justinclift commented Feb 17, 2019

I think there are other bug fixes that we could consider ...

Yeah, they all look pretty simple, and unlikely to break anything. It's fine to commit those (and any other simple looking stuff you want) to the 3.11.x branch. 😄

@justinclift
Copy link
Member Author

In Linux, it works like a charm 😉 but yes I agree on releasing as is and publicize that it is not yet supported in Windows and Mac.

Been thinking over this today. Yeah, I think that'll be the way to go. 😄

@mgrojo
Copy link
Member

mgrojo commented Feb 17, 2019

Yeah, they all look pretty simple, and unlikely to break anything. It's fine to commit those (and any other simple looking stuff you want) to the 3.11.x branch. 😄

Am I still on time for adding those commits?

@justinclift
Copy link
Member Author

Yeah, go for it. Still doing builds to test #1595 at the moment. Might not have everything wrapped up for another day anyway. 🤷‍♂️

@mgrojo
Copy link
Member

mgrojo commented Feb 17, 2019

I've cherry-picked only three of the commits. The remaining ones, although simple, raise conflicts, so it would require time to fix and check. For the moment, I leave it as is.

@justinclift
Copy link
Member Author

Thanks heaps @mgrojo, sounds good. 😄

@justinclift
Copy link
Member Author

justinclift commented Feb 18, 2019

@MKleusberg Windows 3.11.1 binaries are ready for signing:

When that's done, there's a new (Draft status) 3.11.1 Release ready to receive them. The SHA256 checksums at the bottom will need updating for the new signed version of the files.

The macOS binary has already been signed and attached to the new release, so you're ok to hit the Publish button when the Windows ones are added. 😄

@MKleusberg
Copy link
Member

Aaand it's published 😄 I have already updated the README file and the issue templates in the master branch. The binaries still need to be uploaded to our Website plus updating of the website itself. When that's done, the currentrelease file can be updated.

@justinclift
Copy link
Member Author

justinclift commented Feb 18, 2019

Excellent, thanks heaps!

I'm about to get some sleep, so will get all this stuff done after that. 😄

@justinclift justinclift removed the release blocker Bugs that are serious enough to block our next release label Feb 18, 2019
@justinclift justinclift unpinned this issue Feb 18, 2019
@justinclift
Copy link
Member Author

justinclift commented Feb 18, 2019

The download cluster and main website have been updated for 3.11.1. 😉

@justinclift
Copy link
Member Author

justinclift commented Feb 20, 2019

Its been 24 hours, and no major show-stopper type bugs have been reported yet.

I've just updated the currentrelease file, so the update prompt starts happening for people. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants