Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to make Phue autocomplete and some cleanup #84

Merged
merged 3 commits into from
Sep 28, 2014
Merged

Some changes to make Phue autocomplete and some cleanup #84

merged 3 commits into from
Sep 28, 2014

Conversation

Mahlstrom
Copy link
Contributor

Hi,
First, thanks for making this! Made my life much easier :)

I noticed that I didn't get any autocompletions on some returns from client so I fixed that with setting the return to ObjectType[] instead of array.
At the same time i did some "clean up" on the PHPDoc strings.
Hope you include these changes and if you don't, I totally respect your decision.

Best Regards,
Magnus Ahlstrom

Mahlstrom added 2 commits September 27, 2014 08:07
Added vendor folder in .gitignore
Added .idea (PhpStorm) folder in .gitignore
Changed return statements of type array to ObjectType[] where it was needed
@sqmk
Copy link
Owner

sqmk commented Sep 28, 2014

I'm happy to approve this once you get your build passing CI. A good number of PHPCS issues with you using tabs instead of spaces. See PSR-2 guidelines.

@Mahlstrom
Copy link
Contributor Author

Oh, missed that I was using our company settings.
I have now changed from space to 4 spaces.

Magnus Ahlström | Technical Project Manager, Radio Play | SBS Discovery Radio
A: Gjörwellsgatan 30 | Box 34108 | 100 26 Stockholm | Sweden
T: +46 (0)8 450 33 15 | M: +46 (0)766 319 955
W: SBS Discoveryhttp://sbsdiscovery.se/ | Radio Playhttp://www.radioplay.se/

[http://file.sbsradio.se/footer/originals/SBSDiscovery-filer/image001.png]

Från: Michael Squires <notifications@github.commailto:notifications@github.com>
Svara till: sqmk/Phue <reply@reply.github.commailto:reply@reply.github.com>
Datum: Sunday 28 September 2014 02:03
Till: sqmk/Phue <Phue@noreply.github.commailto:Phue@noreply.github.com>
Kopia: "Ahlström Magnus (SBS Discovery Radio)" <magnus.ahlstrom@sbsdiscovery.semailto:magnus.ahlstrom@sbsdiscovery.se>
Ämne: Re: [Phue] Some changes to make Phue autocomplete and some cleanup (#84)

I'm happy to approve this once you get your build passing CI. A good number of PHPCS issues with you using tabs instead of spaces. See PSR-2 guidelines.


Reply to this email directly or view it on GitHubhttps://github.com//pull/84#issuecomment-57069856.

sqmk added a commit that referenced this pull request Sep 28, 2014
Some changes to make Phue autocomplete and some cleanup
@sqmk sqmk merged commit cf05e02 into sqmk:master Sep 28, 2014
@sqmk
Copy link
Owner

sqmk commented Sep 28, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants