Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic require - resolves #78 #77

Closed
wants to merge 2 commits into from

Conversation

simlrh
Copy link

@simlrh simlrh commented Mar 9, 2017

Allows use in React Native by replacing dynamic requires with static ones.

@simlrh simlrh changed the title Remove dynamic require - resolves #43 Remove dynamic require - resolves #78 Mar 9, 2017
@simlrh
Copy link
Author

simlrh commented Mar 9, 2017

Actually resolves #78, I opened an issue in the wrong repo

@simlrh
Copy link
Author

simlrh commented Mar 9, 2017

There were a lot more dynamic requires than I realised, and I had to replace a lot of clean code with a lot of ugly code, so I completely understand if you don't want this PR

Copy link

@sirgalleto sirgalleto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkafrin
Copy link

mkafrin commented Dec 18, 2017

I'm having this same issue with HueJay, and this pull request solves it. It'd be great if it was excepted

@simlrh simlrh closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants