Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for email attachments when there is no Mail.app account configured #47

Open
natan opened this issue Sep 11, 2017 · 3 comments
Labels
enhancement Request for a new feature or improvement to an existing feature

Comments

@natan
Copy link
Collaborator

natan commented Sep 11, 2017

Currently if a customer does not have a Mail.app account configured, Aardvark's email reporter does not include attachments like logs and screenshots (which are so useful). For the common case of Gmail accounts, Aardvark could utilize Google's iOS library to send attachments directly from Aardvark.

@dfed
Copy link
Collaborator

dfed commented Sep 11, 2017

I'd suggest adding a subpod with an EmailReporter subclass that has more fleshed-out Google support (and the Google library dependency) rather than shoving increased binary size onto all customers.

Thoughts on that approach? Not sure what the best binary size / simplicity of adoption trade-off is.

@natan
Copy link
Collaborator Author

natan commented Sep 11, 2017

Good point! This guide seems to go through the same exercise, with recommendations: http://www.dbotha.com/2014/12/04/optional-cocoapod-dependencies/

@NickEntin
Copy link
Collaborator

cc @EricMuller22

@NickEntin NickEntin added the enhancement Request for a new feature or improvement to an existing feature label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants