Aligns views via bounds and center #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickEntin
force-pushed
the
entin/align-via-bounds-and-center
branch
from
abbf895
to
14ac7b7
Compare
Currently we perform layout by setting views' frames. Using `frame` for layout has some significant disadvantages, most notably that `frame` is undefined when the view's `transform` is not the identity transform. This updates our alignment code to ignore transforms in the view hierarchy.
NickEntin
force-pushed
the
entin/align-via-bounds-and-center
branch
from
1c067f6
to
22fec27
Compare
efirestone
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we perform layout by setting views' frames. Using
framefor layout has some significant disadvantages, most notably thatframeis undefined when the view'stransformis not the identity transform.This updates our alignment code to ignore transforms in the view hierarchy.
See #49 for more details.