Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve alignment behavior when aligning to views with non-zero bounds origins #72

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Improve alignment behavior when aligning to views with non-zero bounds origins #72

merged 1 commit into from
Nov 23, 2021

Conversation

NickEntin
Copy link
Collaborator

Resolves #54

NickEntin
NickEntin commented Nov 23, 2021
View reviewed changes
Paralayout/UIView+Alignment.swift

/// Align to the position in the target view's bounds, ignoring any origin offset. This is most commonly used
/// when aligning sibling views in a hierarchy.
case untransformedFrame
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's likely a more accurate name for this, but I can't think of one at the moment.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a tough one to name😅
What do you think about:
.boundsWithoutOffset

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe... I think it might actually be better to name it by the intended usage, e.g. interior/exterior. I'm gonna go ahead and merge this and file an issue to think about a better name before the 1.0 release.

@NickEntin NickEntin merged commit 9214217 into square:develop/1.0 Nov 23, 2021
@NickEntin NickEntin mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliceAponasko AliceAponasko AliceAponasko approved these changes

@cocoalabs cocoalabs cocoalabs approved these changes

@efirestone efirestone Awaiting requested review from efirestone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickEntin @cocoalabs @AliceAponasko