Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to AndroidX #19

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Migration to AndroidX #19

merged 3 commits into from
Oct 23, 2019

Conversation

felipehjcosta
Copy link
Contributor

@felipehjcosta felipehjcosta commented Feb 25, 2019

This PR is responsible for migrating from Support Library to AndroidX. Besides that, Android Gradle Plugin was upgraded as well.

We should not expect any behavior change.

Feel free to ask me anything.

AndroidX requires minSdk 14.
@rupinr
Copy link

rupinr commented Apr 15, 2019

@JakeWharton Please pull this if everything looks good from your side.

@emartynov
Copy link

Any prio to this small MR?

Copy link
Collaborator

@jrodbx jrodbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the dependencies could be refreshed, but that can also be done in a follow-up

@yurimachioni
Copy link

Can anyone merge please ?

@jrodbx jrodbx merged commit 1706d4d into square:master Oct 23, 2019
@jrodbx
Copy link
Collaborator

jrodbx commented Oct 23, 2019

Sorry for the delay here. Just got perms.

@jrodbx
Copy link
Collaborator

jrodbx commented Oct 23, 2019

Closes #17

@emartynov
Copy link

No worries! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants