Fix panic in explainCipher for TLS 1.3 ciphers #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csstaub
requested review from
mcpherrinm,
stfinney,
wtmcc,
jbpeirce,
mbyczkowski,
alokmenghrajani and
mweissbacher
mbyczkowski
approved these changes
Jun 7, 2019
| @@ -3,7 +3,7 @@ | |||
| language: go | |||
|
|
|||
| go: | |||
| - '1.11.x' | |||
| - '1.12.x' | |||
There was a problem hiding this comment.
It might be worth to test the last 2 releases, so:
- '1.11.x'
- '1.x'
There was a problem hiding this comment.
Won't work in 1.11 though, as tls.VersionTLS13 is not defined there
There was a problem hiding this comment.
Very good point! That also means we should update the README to mention certigo requires Go 1.12 to compile.
alokmenghrajani
approved these changes
Jun 7, 2019
mbyczkowski
added a commit
that referenced
this pull request
Jun 16, 2019
As of #185, certigo requires Go 1.12 to build.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic in explainCipher for TLS 1.3 ciphers. See #184.