This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Added config options to allow binding servers to a particular interface #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. Thanks for the contribution. We're in the middle of a drawn-out - and delayed - merge of another fork of Cube, so apologies if this doesn't get any attention for a while. As that process moves along we'll revisit all pull requests and try to get them landed. |
|
It's partially done in the merge, I'll complete it when I can :) |
|
Backported it in #129. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a external and internal interface on a cube server you probably don't want to accept any traffic on the external interface. The simplest way to achieve this is to bind to an IP when starting the server. This pull adds and implements these additional options. If unset or null behaviour is unchanged (listen on all), if set servers are bound to that host.