This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Rename entryPoints to injects. #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
This is closer to what we actually do. It's a type that can be injected. There's a slight bit of ambiguity because we use 'inject' to describe types that are included implicitly. I don't anticipate this to be a problem in practice.
|
I'm going to merge in anticipation of agreement from @cgruber since no further discussions were made on the referenced issue. |
JakeWharton
added a commit
that referenced
this pull request
May 1, 2013
Rename entryPoints to injects.
|
I'm Internet-free for the next three days so I can't agree or disagree |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is closer to what we actually do. It's a type that can be
injected. There's a slight bit of ambiguity because we use 'inject'
to describe types that are included implicitly. I don't anticipate
this to be a problem in practice.