Upgrade to d3 v4 #20
Merged
Upgrade to d3 v4 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
force-pushed
the
margolis/upgrade-to-d3-v4
branch
from
1266090
to
e37638c
Compare
|
Ok this is good to go now! |
|
In the spirit of Wikipedia's Be Bold....merging! PR's welcome 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @RandomEtc @bhvaleri
This is a WIP -- most of it was easy, the
d3.layout.stack→d3.stackis a big change, I didn't get that working yet.I'll also need to do another pass to think about how to explain the
d3.selection.mergeimmutable changes and do a read-through to make sure the copy all makes sense