This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Rely on inheritance for building referenced classes. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll get to tests eventually... #131 |
|
LGTM |
| @SuppressWarnings("unchecked") | ||
| Iterable<? extends HasClassReferences> concat = | ||
| Iterables.concat(super.referencedClasses(), implementedTypes, methodWriters, | ||
| nestedTypeWriters, fieldWriters.values(), explicitImports, ImmutableSet.of(name)); |
There was a problem hiding this comment.
I think nested can be dropped here.
There was a problem hiding this comment.
Keeping nested until I figure out it's behavior more. I think #77 might be related.
This is better than forcing all subclasses to update when new types are referenced in super classes.
JakeWharton
force-pushed
the
jw/super-referenced-classes
branch
from
3d1650a
to
e7e2057
Compare
JakeWharton
added a commit
that referenced
this pull request
Dec 10, 2014
Rely on inheritance for building referenced classes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better than forcing all subclasses to update when new types are referenced in super classes.