Top-level functions. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
May 15, 2017
| @@ -227,6 +227,12 @@ class KotlinFile private constructor(builder: KotlinFile.Builder) { | |||
| return this | |||
| } | |||
|
|
|||
| fun addFun(funSpec: FunSpec): Builder { | |||
| require (!funSpec.isConstructor) { "cannot add a constructor to file $fileName" } | |||
There was a problem hiding this comment.
Subconsciously, check and require feel sooo keywordey
JakeWharton
reviewed
May 15, 2017
| val source = KotlinFile.builder(tacosPackage, "Taco") | ||
| .addFun(FunSpec.builder("a").build()) | ||
| .addType(TypeSpec.classBuilder("B").build()) | ||
| .addFun(FunSpec.builder("c").build()) |
There was a problem hiding this comment.
Can you make one of these explicitly PUBLIC and ensure the modifier isn't emitted?
swankjesse
force-pushed
the
jwilson.0514.top_level_functions
branch
from
b71198a
to
486f6c7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.