New EventListener + HeapDumper APIs #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
force-pushed
the
py/heap_dumper_api
branch
from
4147c89
to
419197d
Compare
pyricau
changed the title
Inspired from #2197 Co-authored-by: itznotabug <itznotabug@gmail.com>
pyricau
commented
Dec 23, 2021
| /** | ||
| * When receiving a [HeapDump] event, starts a WorkManager worker that performs heap analysis. | ||
| */ | ||
| object WorkManagerHeapAnalyzer : EventListener { |
There was a problem hiding this comment.
@ItzNotABug thanks for #2197 ! It was super helpful to get this done.
There was a problem hiding this comment.
Great! Happy to help. :)
pyricau
force-pushed
the
py/heap_dumper_api
branch
from
c3455df
to
1d9f654
Compare
- Support job cancelation for remote job - Fix bug that led to job cancelation when :leakcanary starts - Ensuring Events are all serializable - Moved AndroidDebugHeapAnalyzer to internal
pyricau
force-pushed
the
py/heap_dumper_api
branch
from
1d9f654
to
34d5023
Compare
| * } | ||
| * ``` | ||
| */ | ||
| val eventListeners: List<EventListener> = listOf( |
alhah
added a commit
to KwaiAppTeam/KOOM
that referenced
this pull request
Feb 24, 2022
…ions and support leakcanary custom dumper square/leakcanary#2237 Signed-off-by: xueqiushi <xueqiushi@kuaishou.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1682 (EventListener API)
Fixes #2192 (ForegroundServiceStartNotAllowedException)
Fixes #2214 (disable heap dumping toast)
HeapDumper API makes it possible to ship #2121 (fast native dump) outside the LeakCanary repo: