Revisit heap growth detection APIs #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
force-pushed
the
py/update_heap_growth_apis
branch
from
4bac2d4
to
84ed0b8
Compare
pyricau
force-pushed
the
py/update_heap_growth_apis
branch
2 times, most recently
from
eb64157
to
035f217
Compare
pyricau
force-pushed
the
py/update_heap_growth_apis
branch
from
035f217
to
f73dfe3
Compare
swankjesse
reviewed
Apr 19, 2024
shark/shark/src/main/java/shark/AndroidReferenceReaderFactory.kt
Outdated
Show resolved
Hide resolved
swankjesse
approved these changes
Apr 19, 2024
shark/shark/src/main/java/shark/AndroidReferenceReaderFactory.kt
Outdated
Show resolved
Hide resolved
shark/shark/src/main/java/shark/ChainingInstanceReferenceReader.kt
Outdated
Show resolved
Hide resolved
shark/shark/src/main/java/shark/FlatteningFiniteTraversalReferenceReader.kt
Outdated
Show resolved
Hide resolved
…dge was directly connected to all the non outgoing nodes in the data structure compoment. This automatically deduplicates the paths that we get out of heap diffs. We were seeing duplicate entries because a map would be surfaced as a node with growing children, but then an internal element of the map, e.g. the background array or a node from its linked list, would also be surfaced as a distinct node with growing childre. With this solution, essentially each wrapped reference reader now does its own local graph traversal. The isLeafObject property allows to communicate to the larger graph traversal code that a specific node doesn't need to be re explored
pyricau
force-pushed
the
py/update_heap_growth_apis
branch
from
a95cf55
to
56aed02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.