Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog,modal): allow blocking swipe-to-close #566

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

tatems
Copy link
Collaborator

@tatems tatems commented Oct 19, 2023

Describe the problem this PR addresses

Closes #565
Provides a prop to block swiping away dialogs and modals on touch-enabled devices. closeOnSwipeDown is enabled by default to maintain current functionality.

Describe the changes in this PR

  • Add closeOnSwipeDown as a prop on MDialog and MModal components
  • Update MDialog/MModal to check the value of closeOnSwipeDown to enable/disable swipe (nullish values evaluate to enabled)

@tatems tatems requested a review from a team as a code owner October 19, 2023 19:10
@github-actions
Copy link

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

@tatems tatems closed this Oct 19, 2023
@tatems tatems reopened this Oct 19, 2023
@tatems tatems changed the title feat(dialog): allow blocking swipe-to-close feat(dialog,modal): allow blocking swipe-to-close Oct 19, 2023
@tatems tatems merged commit 2691142 into master Oct 20, 2023
7 checks passed
@tatems tatems deleted the disallow-dialog-swipe branch October 20, 2023 13:23
@github-actions
Copy link

🎉 This PR is included in version 19.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow swiping away on dialogs
3 participants