-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adjust sizing of MButton info slot #570
Conversation
Deployed Styleguide and Lab. Notes
|
jw, what is the behavior when the main label (left side) is really really long? does the font size accommodate, so that the text continues to wrap? does it get cut off after two lines? i believe the |
Both slots are supposed to ellipsize but I'm not sure the logic is correctly applying |
Do you mind verifying this behavior? I think it's even more important that this works correctly if we're going to force the info slot to always |
The code shows that both slots should have the class applied, however there aren't any wrapping rules applied so it looks like the text on both slots will wrap, and after all space is exhausted only then will they ellipsise. We can see that behaviour in the screenshot as well as the site it's hosted from, where the presence of the info slot causes the default slot to wrap with or without the changeset. |
note: if your pr title begins with "refactor" i believe merging it won't produce a maker release, if you'd like these changes to be released immediately after merging consider changing the pr title to begin with "fix" if it fixes an issue |
3e39ce8
to
2c88624
Compare
🎉 This PR is included in version 19.6.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the problem this PR addresses
The
information
slot inMButton
currently uses awidth
property inside a flex container, which causes the text to be cut off in situations where the main slot runs long.Describe the changes in this PR
This PR changes the slot to be sized with
flex
properties, specifically setting theflex-basis
so that contents aren't elided.Other information