Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(image): disable transition for safari + unwatch observer after it triggers #573

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

kevinlee11
Copy link
Contributor

@kevinlee11 kevinlee11 commented Dec 11, 2023

Describe the problem this PR addresses

Trying to find additional improvements for Safari perf.

Describe the changes in this PR

Removing the transition as a prop, plus unwatch the observer after it triggers.

@kevinlee11 kevinlee11 requested review from a team as code owners December 11, 2023 21:43
@kevinlee11 kevinlee11 changed the title perf(image): disable transition for safari + unwatch observer after i… perf(image): disable transition for safari + unwatch observer after it triggers Dec 11, 2023
Copy link

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

src/utils/devices.js Outdated Show resolved Hide resolved
src/components/Image/src/Image.vue Show resolved Hide resolved
src/components/Image/src/Image.vue Outdated Show resolved Hide resolved
@kevinlee11 kevinlee11 merged commit e3ff85c into master Dec 11, 2023
4 checks passed
@kevinlee11 kevinlee11 deleted the image-safari-remove-transition branch December 11, 2023 22:22
Copy link

🎉 This PR is included in version 19.6.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants