Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image): wrong condition on shouldGetImageDimensions #574

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(image): wrong condition on shouldGetImageDimensions #574

merged 1 commit into from
Dec 12, 2023

Conversation

kevinlee11
Copy link
Contributor

Describe the problem this PR addresses

Used || instead of && on the shouldGetImageDimensions

@kevinlee11 kevinlee11 requested a review from a team as a code owner December 11, 2023 23:37
@github-actions GitHub Actions
Copy link

Deployed Styleguide and Lab.

Notes
  1. Links may take a few minutes to update after PR is opened or commit is pushed.
  2. Links may become invalidated after PR is merged or closed.
  3. Links for all releases and open PRs can be found on the Maker Deploys page.

@kevinlee11 kevinlee11 merged commit 56c6c75 into master Dec 12, 2023
4 checks passed
@kevinlee11 kevinlee11 deleted the fix-shouldGetImageDimensions branch December 12, 2023 00:48
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 19.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashjtan ashjtan ashjtan approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinlee11 @ashjtan