Update the mobile take home project site based off of the proposed RF… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a screenshot of the website |
|
PR 5 is content-based and I take no opinion on that (you folks own the content). If someone else on the team wants to approve, I'm happy to merge |
kyleve
reviewed
Jan 13, 2022
|
|
||
| Take care to properly handle errors returned from the endpoint (or other network errors like timeouts), and ensure you do not waste network bandwidth – load expensive resources such as large photos on-demand only. Photos at a given URL will never change. Once one is loaded, you do not need to reload the photo. If an employee’s photo changes, they will be given a new photo URL (eg, you can treat the URL as a GUID). | ||
| Build an employee directory app that shows a list of employees from the provided endpoint. |
There was a problem hiding this comment.
Though i guess this is fine if we consider the other endpoints just for testing!
kyleve
reviewed
Jan 13, 2022
kyleve
reviewed
Jan 13, 2022
kyleve
reviewed
Jan 13, 2022
kyleve
reviewed
Jan 13, 2022
kyleve
reviewed
Jan 13, 2022
kyleve
reviewed
Jan 13, 2022
kyleve
approved these changes
Jan 13, 2022
Blisse
force-pushed
the
victorlai.update-take-home
branch
2 times, most recently
from
281ab5a
to
f417151
Compare
…C improvements RFC: https://docs.google.com/document/d/1Yu1bcg9WrqsnNCIWuI38Y9QBFy8oIEYAxgBl2q4FQKM/edit# Had to make some additional wording changes to make things flow a bit better.
Blisse
force-pushed
the
victorlai.update-take-home
branch
from
f417151
to
deaa45f
Compare
|
Fixed one more grammar error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…C improvements
RFC: https://docs.google.com/document/d/1Yu1bcg9WrqsnNCIWuI38Y9QBFy8oIEYAxgBl2q4FQKM/edit#
Had to make some additional wording changes to make things flow a bit better.